From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] build: Add a scheme custom test driver using SRFI-64. Date: Mon, 02 Nov 2015 09:59:28 +0100 Message-ID: <87k2q0n5e7.fsf@gnu.org> References: <87lhaiv30f.fsf@gnu.org> <87h9l54p8p.fsf@gnu.org> <87lhahcxgt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtAxh-0007RF-RP for guix-devel@gnu.org; Mon, 02 Nov 2015 03:59:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtAxe-0008FI-M5 for guix-devel@gnu.org; Mon, 02 Nov 2015 03:59:33 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtAxe-0008FB-IN for guix-devel@gnu.org; Mon, 02 Nov 2015 03:59:30 -0500 In-Reply-To: <87lhahcxgt.fsf@gnu.org> (Mathieu Lirzin's message of "Sun, 01 Nov 2015 20:48:34 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mathieu Lirzin Cc: guix-devel@gnu.org Mathieu Lirzin skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >>> One caveat is that =E2=80=98tests/cpio.scm=E2=80=98 is now failing. >> >> Why is that? Does it relate to this change? > > I didn't try to debug the problem but it has appeared when I started > messing with redirection of the output/error ports. Here is the failure > output. > > test-name: bit-identical to GNU cpio's output > location: /home/mthl/src/gnu/guix/tests/cpio.scm:49 Is GNU cpio available in $PATH? Which version is that? Could you run this test in =E2=80=98master=E2=80=99 to see if the problem shows up? >>> Since this script is not intented to be exclusively used by Guix, I have >>> used a generic copyright notice. I guess Guix is the best place to >>> challenge and improve it, but IMO it will be better hosted elsewhere >>> like in Gnulib. Opinions? >> >> I think we could start using it and testing it for a while in Guix, and >> eventually submit it for inclusion in Gnulib once we are more confident. > > So you recommend to add =E2=80=9Dthis file is part of GNU Guix=E2=80=9D a= nd use =E2=80=9CGNU > Guix=E2=80=9D instead of =E2=80=9Cthis program=E2=80=9D for now? I think you can leave =E2=80=9Cthis program=E2=80=9D so nothing will need t= o be changed when you move it elsewhere. >> However, I=E2=80=99m unsure if we should push it now, or after the relea= se. On >> one hand, I=E2=80=99d rather avoid potentially disrupting changes like t= his >> now. On the other hand, since it makes it easier (and different) to >> report test failures, it=E2=80=99s nice. >> >> How confident are you? :-) > > IMHO we should wait after the next release in order to make this test > driver more bullet proof. Sounds reasonable. Thanks! Ludo=E2=80=99.