From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add Red Eclipse. Date: Wed, 27 Apr 2016 14:14:37 +0200 Message-ID: <87k2jj45aq.fsf@gnu.org> References: <20160423022054.16f7aeb7@openmailbox.org> <571B21C8.3050100@gmx.net> <20160423074645.545cb512@openmailbox.org> <87eg9sd5zq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avOMf-0005jF-C6 for guix-devel@gnu.org; Wed, 27 Apr 2016 08:14:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avOMc-00072Y-1T for guix-devel@gnu.org; Wed, 27 Apr 2016 08:14:45 -0400 In-Reply-To: <87eg9sd5zq.fsf@gmail.com> (Alex Kost's message of "Tue, 26 Apr 2016 13:22:33 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: [...] >> + ;; Create origin records for the many separate data packages. >> + ,@(map (match-lambda >> + ((name hash) >> + (list name >> + (origin >> + (method url-fetch) >> + (uri (string-append "https://github.com/red-= eclipse/" >> + name "/archive/v" versio= n ".tar.gz")) >> + (sha256 (base32 hash)) >> + (file-name (string-append name "-" version "= .tar.gz")))))) >> + data-sources))) > > > I'm afraid this is not reliable. I mean that all these data sources > have the same "v1.5.3" tags. I doubt that once there will be a new > release of the base repository, they also will tag all the data repos to > the new version. > > I think it's OK to do it like this for now, but if the mentioned problem > will happen after the next release, we'll have to change this method > (probably by making private "red-eclipse-" packages for all data > NAMEs). Yeah I think it=E2=80=99s OK. We can always adjust it when a new release c= omes out. >> + "Red Eclipse is an open-source arena shooter, created from the C= ube2 s/open-source// >> + ;; License information available in detail at the following link: >> + ;; http://redeclipse.net/wiki/License >> + (license (list license:expat >> + license:zlib >> + license:cc-by-sa3.0 >> + license:cc-by3.0 >> + license:cc0))))) Would be worth mentioning that it=E2=80=99s a combination of all these lice= nses, IIUC. Looks like we=E2=80=99re there modulo this and the minor indentation issue? Would you like to apply it with these changes, Alex? Thank you all! Ludo=E2=80=99.