From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: procps: Make procps build on non Linux systems. Date: Thu, 28 Apr 2016 14:19:41 +0200 Message-ID: <87k2jigc2q.fsf@gnu.org> References: <56b93557-6c80-f1d6-5978-cad718674a14@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avkv6-0005Vg-06 for guix-devel@gnu.org; Thu, 28 Apr 2016 08:19:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avkv2-00040T-0K for guix-devel@gnu.org; Thu, 28 Apr 2016 08:19:47 -0400 In-Reply-To: <56b93557-6c80-f1d6-5978-cad718674a14@gmail.com> (Manolis Ragkousis's message of "Thu, 28 Apr 2016 11:30:09 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Manolis Ragkousis Cc: guix-devel@gnu.org Manolis Ragkousis skribis: > From 00c2d2ec11a75e3d74704150488e73ee7c8c6fe8 Mon Sep 17 00:00:00 2001 > From: Manolis Ragkousis > Date: Wed, 27 Apr 2016 23:33:56 +0300 > Subject: [PATCH] gnu: procps: Make procps build on non Linux systems. > > * gnu/packages/patches/procps-non-linux.patch.patch: New patch. > * gnu/packages/linux.scm (procps)[source]: Use it. > * gnu/local.mk (dist_patch_DATA): Add it. [...] > --- /dev/null > +++ b/gnu/packages/patches/procps-non-linux.patch Please add a couple of lines saying what it does and what its upstream status is. OK for =E2=80=98core-updates=E2=80=99 with this change! Then I second John=E2=80=99s comment: you should propose the change upstrea= m. They might do it differently (by checking for the header and function at configure time, typically), but I guess there=E2=80=99s no reason why they = would refuse it. Thank you! Ludo=E2=80=99.