From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: HTTP server invalid date header
Date: Sun, 08 May 2016 22:10:26 +0200
Message-ID: <87k2j42tvx.fsf@gnu.org>
References: <idjlh4591ae.fsf@bimsb-sys02.mdc-berlin.net>
	<877ffgphrb.fsf@gnu.org> <87twikw4s1.fsf@elephly.net>
	<87twiiapui.fsf@gnu.org> <idjeg9k5vl4.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53597)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1azV2B-0008Kh-BB
	for guix-devel@gnu.org; Sun, 08 May 2016 16:10:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1azV27-000390-2P
	for guix-devel@gnu.org; Sun, 08 May 2016 16:10:34 -0400
In-Reply-To: <idjeg9k5vl4.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Mon, 2 May 2016 17:27:19 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Ricardo Wurmus <rekado@elephly.net> skribis:
>>
>>> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>>>
>>>> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>>>>
>>>>> I tested JUnit previously with the log4j-api package, but I cannot
>>>>> submit this right now due to a bug(?) in Guile=E2=80=99s HTTP client,=
 which
>>>>> makes it impossible for me to download the sources of its dependencie=
s,
>>>>> such as this one:
>>>>>
>>>>>     http://central.maven.org/maven2/org/osgi/org.osgi.core/6.0.0/org.=
osgi.core-6.0.0-sources.jar
>>>>>     ERROR: Bad Date header: Wed, 30 Jul 2014  3:47:42 GMT
>>>>
>>>> ISTR you were working on a workaround for this issue.  What=E2=80=99s =
the
>>>> status?
>>>
>>> I got it fixed (after wasting a lot of time wondering why it would not
>>> work as I had patched the wrong file), but the fix isn=E2=80=99t really=
 pretty.
>>
>> [...]
>>
>>> From c98ca436bafe8077edaf3125b529ea32fbd48611 Mon Sep 17 00:00:00 2001
>>> From: Ricardo Wurmus <rekado@elephly.net>
>>> Date: Fri, 29 Apr 2016 22:12:24 +0200
>>> Subject: [PATCH] build: Accept dates with space-padded hour field.
>>>
>>> * guix/build/download.scm: Replace "parse-rfc-822-date" from the (web
>>>   http) module.
>>
>> I don=E2=80=99t think it=E2=80=99s worse than the original.  ;-)
>>
>> To help maintenance, could you make sure there=E2=80=99s a Guile bug num=
ber for
>> this one?  And then you can submit this change to Guile itself, and
>> after that backport it to Guix (with a reference to the Guile bug and
>> commit.)
>>
>> Would that work for you?
>
> Sure, no problem.  The bug I submitted to bug-guile received number
> 23421.  I already submitted my patch to guile-devel, but it seems to be
> stuck in the queue for now.  Once it has been committed I=E2=80=99ll back=
port
> the change to Guix.

Fixed in Guile commit 16050431f29d56f80c4a8253506fc851b8441840 (not a
great fix due to limitations in the =E2=80=98string-match?=E2=80=99 macro t=
here.)

The backport will probably require a copy of both =E2=80=98string-match?=E2=
=80=99 and
=E2=80=98parse-rfc-822-date=E2=80=99.

Thanks,
Ludo=E2=80=99.