From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Alex Griffin <a@ajgrf.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add gnome-mpv.
Date: Thu, 7 Jul 2016 09:10:06 +0200 [thread overview]
Message-ID: <87k2gxzzxt.fsf@mdc-berlin.de> (raw)
In-Reply-To: <1467849895.1613559.659003001.5BC78E49@webmail.messagingengine.com>
Hi Alex,
> This patch adds gnome-mpv, a simple GTK+ frontend to the mpv video
> player.
Thank you for the patch!
> +(define-public gnome-mpv
> + (package
> + (name "gnome-mpv")
> + (version "0.9")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/gnome-mpv/gnome-mpv/releases/download/v"
> + version "/gnome-mpv-" version ".tar.xz"))
This line looks a bit long to me. Have you checked with “guix lint
gnome-mpv”?
> + (sha256
> + (base32
> + "06pgxl6f3kkgxv8nlmyl7gy3pg55sqf8vgr8m6426mlpm4p3qdn0"))))
> + (native-inputs
> + `(("intltool" ,intltool)
> + ("pkg-config" ,pkg-config)))
> + (inputs
> + `(("gtk+" ,gtk+)
> + ("libepoxy" ,libepoxy)
> + ("mpv" ,mpv)))
> + (build-system glib-or-gtk-build-system)
> + (home-page "https://github.com/gnome-mpv/gnome-mpv")
> + (synopsis "Simple GTK+ frontend for mpv")
> + (description "GNOME MPV is a simple GTK+ frontend for mpv. GNOME MPV
> +interacts with mpv via the client API exported by libmpv, allowing access to
> +mpv's powerful playback capabilities.")
> + (license license:gpl3+)))
> +
The rest looks good to me.
~~ Ricardo
next prev parent reply other threads:[~2016-07-07 7:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 0:04 [PATCH 2/2] gnu: Add gnome-mpv Alex Griffin
2016-07-07 7:10 ` Ricardo Wurmus [this message]
2016-07-07 14:39 ` Alex Griffin
2016-07-07 17:07 ` Eric Bavier
2016-07-07 17:17 ` Efraim Flashner
2016-07-10 4:13 ` Efraim Flashner
2016-07-12 15:34 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2gxzzxt.fsf@mdc-berlin.de \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=a@ajgrf.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.