From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant. Date: Wed, 28 Sep 2016 23:15:12 +0200 Message-ID: <87k2dv20bj.fsf@gnu.org> References: <20160926103447.31830-1-david@craven.ch> <20160926103447.31830-4-david@craven.ch> <20160926132344.GA23258@jocasta.intra> <20160926164934.GA25011@jocasta.intra> <8760pgubgx.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpMCG-0006Cz-8l for guix-devel@gnu.org; Wed, 28 Sep 2016 17:15:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpMCC-0007kp-4u for guix-devel@gnu.org; Wed, 28 Sep 2016 17:15:19 -0400 In-Reply-To: <8760pgubgx.fsf@netris.org> (Mark H. Weaver's message of "Tue, 27 Sep 2016 20:14:38 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel Mark H Weaver skribis: > Our conventions for commit logs, which follow the GNU Coding Standards > for Change Logs (see section 6.8 of the GNU Coding Standards), is that > explanations belong in the comments of the code itself, not in the > commit log. If that had been done in the example you give above, you > would have known why the line was needed in a small fraction of the time > that it must have taken you to perform all the steps above. > > However, I agree that commits that _remove_ code should include the > rationale in the commit log, if the reason is not obvious and if there's > no sensible place to put the explanation in the code. > > What do you think? +1 Ludo=E2=80=99.