From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: gnu: artanis: Remove implied $(DESTDIR) usage.
Date: Mon, 17 Oct 2016 03:13:20 +0100
Message-ID: <87k2d7oh8f.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me>
References: <1476582044.11070.21.camel@adfeno-VPCEG17FB>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53579)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1bvxQe-0007Ee-Qf
	for guix-devel@gnu.org; Sun, 16 Oct 2016 22:13:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1bvxQZ-0006oD-PK
	for guix-devel@gnu.org; Sun, 16 Oct 2016 22:13:28 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57455)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mbakke@fastmail.com>) id 1bvxQZ-0006o5-Kr
	for guix-devel@gnu.org; Sun, 16 Oct 2016 22:13:23 -0400
In-Reply-To: <1476582044.11070.21.camel@adfeno-VPCEG17FB>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Adonay Felipe Nogueira <adfeno@openmailbox.org>, guix-devel@gnu.org

Adonay Felipe Nogueira <adfeno@openmailbox.org> writes:

> My first patch to Guix project, I hope this helps. :)

Welcome and thanks for this patch! :)

The current artanis package has a bug where the install location is set
to "$out/$out/share/guile/site/2.0". This patch fixes that by installing
to "$out/share/guile/site/2.0". I can load it from the Guile REPL now.

However, the same files are still present in
/gnu/store/...-artanis-0.1.2/gnu/store/...-artanis-0.1.2 as before. It
seems to be installed to both $out and $out/$out. Do you think you can
prevent this from happening as well?

Other than that I only have one remark:

[...]

> diff --git a/gnu/packages/patches/artanis-fix-Makefile.in.patch b/gnu/packages/patches/artanis-fix-Makefile.in.patch
> new file mode 100644
> index 0000000..d2c19f1
> --- /dev/null
> +++ b/gnu/packages/patches/artanis-fix-Makefile.in.patch
> @@ -0,0 +1,69 @@
> +Applies until an Artanis release comes with patches #9130 and #9131
> +applied.

Please mention the upstream commit hash or bug report here, so that
the next person can easily tell whether this is still needed or not.

Can you send an updated patch?

Thanks!