Re: [PATCH] gnu: Add whois.

[ng0 <ng0@we.make.ritual.n0.is>]

Marius Bakke <mbakke@fastmail.com> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> * gnu/packages/networking.scm (whois): New variable.
>
> Thanks! This works for me. I have a couple of remarks that can be added
> before committing if you agree, no need to send an updated patch.
>
> * The source headers seems to indicate that this is GPL2+.
> * The only reference to this program on the home page is a link to
>   GitHub, do you think we should use that as home-page?
> * Gettext only seems used for building locales and is not referenced at
>   runtime, perhaps it should be a native-input?

Ok.

> * The Debian package is built with HAVE_ICONV=1, should we set that too?

I can send an updated patch with libiconv in the inputs. This is when
you use a libc which does not provide a (usable) iconv, which is why
Gentoo provides the option to build it with this too. As we are
_currently_ only providing options to do one libc globally this is not
so inmportant. I will even build uclibc-ng (I am working on that) with
an outside iconv because reportedly their iconv is in bad shape.

So with this information, should I send a new patch which adds libiconv
and the build option?

> Additionally it installs locales, but looks for /usr/share/locale at
> runtime. Fixing this would probably require upstream help, I don't want
> to hardcode either "/run/current-system/locale" or ~/.guix-profile. The
> current version probably works on foreign distros, if nothing else.

If you know how to fix it, try to bring it to upstream or include a
patch / substitute phase at our end?

> Are these changes sensible?
>