From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: %static-inputs: Use bash from PATH in bootstrap tar. Date: Wed, 19 Oct 2016 21:48:11 +0200 Message-ID: <87k2d45ddw.fsf@gnu.org> References: <7ttwc9fy7o.fsf@gmail.com> <871szc73pi.fsf@gnu.org> <20161019171345.GB17867@macbook42.flashner.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwwqY-0000AY-NL for guix-devel@gnu.org; Wed, 19 Oct 2016 15:48:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwwqU-0005ct-Sd for guix-devel@gnu.org; Wed, 19 Oct 2016 15:48:18 -0400 In-Reply-To: <20161019171345.GB17867@macbook42.flashner.co.il> (Efraim Flashner's message of "Wed, 19 Oct 2016 20:13:45 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel@gnu.org Efraim Flashner skribis: > On Wed, Oct 19, 2016 at 05:34:17PM +0200, Ludovic Court=C3=A8s wrote: >> csanchezdll@gmail.com (Carlos S=C3=A1nchez de La Lama) skribis: >>=20 >> > See >> > . >>=20 >> Could you put this URL next to the =E2=80=9CDo not use /bin/sh=E2=80=9D = comment? >>=20 >> > gnu/packages/make-bootstrap.scm (%static-inputs): Use bash from PATH. >>=20 >> Otherwise LGTM, thanks! >>=20 >> Ludo=E2=80=99. >>=20 > > Was this tested with the other bootstrap binaries? It changes execv("/bin/sh", =E2=80=A6) to execvp("sh", =E2=80=A6) so it loo= ks right. > I'm still having trouble with the aarch64 ones, didn't check if/how it > affected the ones that are already in Guix (which I assume would be > not at all) What kind of problems? After this patch? Thanks, Ludo=E2=80=99.