From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 1/3] gnu: lua: Update to 5.3.3. Date: Sat, 05 Nov 2016 18:43:39 +0000 Message-ID: <87k2ch6a3o.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20161031132944.2353-1-mbakke@fastmail.com> <20161031132944.2353-2-mbakke@fastmail.com> <20161031175534.GB27555@jasmine> <87oa20uleu.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c35wQ-0000VN-0w for guix-devel@gnu.org; Sat, 05 Nov 2016 14:43:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c35wM-0004SK-Up for guix-devel@gnu.org; Sat, 05 Nov 2016 14:43:46 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:46874) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c35wM-0004Rz-Qb for guix-devel@gnu.org; Sat, 05 Nov 2016 14:43:42 -0400 In-Reply-To: <87oa20uleu.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Marius Bakke writes: > Leo Famulari writes: > >> On Mon, Oct 31, 2016 at 01:29:42PM +0000, Marius Bakke wrote: >>> * gnu/packages/lua.scm (lua): Update to 5.3.3. >>> [source]: Use https URL. >>> [home-page]: Use https URL. >>> (lua-5.2): New variable. >>> (lua-5.1)[source]: Use https URL. >>> --- >>> gnu/packages/lua.scm | 23 ++++++++++++++++++----- >>> 1 file changed, 18 insertions(+), 5 deletions(-) >>>=20 >>> diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm >>> index 8fdba61..55e529e 100644 >>> --- a/gnu/packages/lua.scm >>> +++ b/gnu/packages/lua.scm >>> @@ -40,13 +40,13 @@ >>> (define-public lua >>> (package >>> (name "lua") >>> - (version "5.2.4") >>> + (version "5.3.3") >>> (source (origin >>> (method url-fetch) >>> - (uri (string-append "http://www.lua.org/ftp/lua-" >>> + (uri (string-append "https://www.lua.org/ftp/lua-" >>> version ".tar.gz")) >>> (sha256 >>> - (base32 "0jwznq0l8qg9wh5grwg07b5cy3lzngvl5m2nl1ikp6vqssm= f9qmr")) >>> + (base32 "18mcfbbmjyp8f2l9yy7n6dzk066nq6man0kpwly4bppphil= c04si")) >>> (patches (search-patches "lua-pkgconfig.patch" >>> "lua52-liblua-so.patch")))) >> >> Does this lua52-liblua-so.patch still apply / is it still needed for Lua >> 5.3? I remember that there were significant differences between how Lua >> 5.1 and 5.2 in terms of building a dynamic Lua library. >> >> If so, I guess we should rename it. > > I tried building 5.3 initially without patches and noticed the shared > library was not created. It applies cleanly and works as advertised. > > Should I rename it to just lua-liblua-so.patch? IMO the version number > is useful information, even if it applies for a later minor release. I'm > in favor of keeping it, and create the lua54 equivalent if/when needed. How should we proceed with this? I think renaming it to "lua-liblua-so.patch" is fine, since it applies to the current release. Another option is "lua52-lua53-liblua-so.patch", although we will have to keep renaming it for all future versions it applies to in that case, which seems like unnecessary noise. The third option is of course keeping the lua52 name, but I see how that can be confusing for the next code spelunker. I don't have a strong opinion either way, but will go ahead with the first option unless there are any objections. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYHihbAAoJEKKgbfKjOlT6ERsIAIOHToQSdQzskIPCp9ylnuTA lK5zC9SvB63bQ7qqMrE5OxFY51a+QD+PnqSrVNu0g7heqvUJ2ntm54JprdmQDCCC zUfANhcAfICIp7n6+fKm31Qyjo2X9lnrU8j+e1eGr1x1UIVFMUP7g+oMMiUH9mCJ C1RDKaxw5a6P/5kwRaYrbyOx7eH6GZxFIiYv5nIa8/vt4DjnTwLrpCfWFdstnGww WUNZ4H2fKWwT83/ADAC93SYLKCaJgZhygiJII5N/IFbHMjb0CyZ1+o6/K8LRNpoO CKaioHfCKeNSRrbNwFr5PII7kdLt1hDWVOFsnUalC8cp/LQVV6zuP2JYKo41me8= =uyHe -----END PGP SIGNATURE----- --=-=-=--