all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/3] gnu: lua: Update to 5.3.3.
Date: Sat, 05 Nov 2016 18:43:39 +0000	[thread overview]
Message-ID: <87k2ch6a3o.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87oa20uleu.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 2568 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Mon, Oct 31, 2016 at 01:29:42PM +0000, Marius Bakke wrote:
>>> * gnu/packages/lua.scm (lua): Update to 5.3.3.
>>> [source]: Use https URL.
>>> [home-page]: Use https URL.
>>> (lua-5.2): New variable.
>>> (lua-5.1)[source]: Use https URL.
>>> ---
>>>  gnu/packages/lua.scm | 23 ++++++++++++++++++-----
>>>  1 file changed, 18 insertions(+), 5 deletions(-)
>>> 
>>> diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
>>> index 8fdba61..55e529e 100644
>>> --- a/gnu/packages/lua.scm
>>> +++ b/gnu/packages/lua.scm
>>> @@ -40,13 +40,13 @@
>>>  (define-public lua
>>>    (package
>>>      (name "lua")
>>> -    (version "5.2.4")
>>> +    (version "5.3.3")
>>>      (source (origin
>>>               (method url-fetch)
>>> -             (uri (string-append "http://www.lua.org/ftp/lua-"
>>> +             (uri (string-append "https://www.lua.org/ftp/lua-"
>>>                                   version ".tar.gz"))
>>>               (sha256
>>> -              (base32 "0jwznq0l8qg9wh5grwg07b5cy3lzngvl5m2nl1ikp6vqssmf9qmr"))
>>> +              (base32 "18mcfbbmjyp8f2l9yy7n6dzk066nq6man0kpwly4bppphilc04si"))
>>>               (patches (search-patches "lua-pkgconfig.patch"
>>>                                        "lua52-liblua-so.patch"))))
>>
>> Does this lua52-liblua-so.patch still apply / is it still needed for Lua
>> 5.3? I remember that there were significant differences between how Lua
>> 5.1 and 5.2 in terms of building a dynamic Lua library.
>>
>> If so, I guess we should rename it.
>
> I tried building 5.3 initially without patches and noticed the shared
> library was not created. It applies cleanly and works as advertised.
>
> Should I rename it to just lua-liblua-so.patch? IMO the version number
> is useful information, even if it applies for a later minor release. I'm
> in favor of keeping it, and create the lua54 equivalent if/when needed.

How should we proceed with this? I think renaming it to
"lua-liblua-so.patch" is fine, since it applies to the current release.

Another option is "lua52-lua53-liblua-so.patch", although we will have
to keep renaming it for all future versions it applies to in that case,
which seems like unnecessary noise.

The third option is of course keeping the lua52 name, but I see how that
can be confusing for the next code spelunker.

I don't have a strong opinion either way, but will go ahead with the
first option unless there are any objections.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

  reply	other threads:[~2016-11-05 18:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 13:29 [PATCH 0/3] Update lua and nmap Marius Bakke
2016-10-31 13:29 ` [PATCH 1/3] gnu: lua: Update to 5.3.3 Marius Bakke
2016-10-31 17:55   ` Leo Famulari
2016-10-31 23:51     ` Marius Bakke
2016-11-05 18:43       ` Marius Bakke [this message]
2016-11-05 18:49         ` Leo Famulari
2016-11-06 16:21           ` Marius Bakke
2016-10-31 13:29 ` [PATCH 2/3] gnu: wireshark: Use lua-5.2 Marius Bakke
2016-10-31 17:55   ` Leo Famulari
2016-10-31 13:29 ` [PATCH 3/3] gnu: nmap: Update to 7.31 Marius Bakke
2016-10-31 17:53   ` Leo Famulari
2016-11-01  0:00     ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2ch6a3o.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.