all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Ricardo Wurmus <rekado@elephly.net>, guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: lvtk: Build UI library.
Date: Sat, 03 Dec 2016 22:04:44 +0100	[thread overview]
Message-ID: <87k2bgbu6r.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20161203194209.19164-1-rekado@elephly.net>

[-- Attachment #1: Type: text/plain, Size: 1372 bytes --]

Ricardo Wurmus <rekado@elephly.net> writes:

> * gnu/packages/audio.scm (lvtk)[inputs]: Add gtkmm-2.
> [arguments]: Pass "-std=c++11" flag.
> ---
>  gnu/packages/audio.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 5de0681..d7bdc01 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -1653,9 +1653,16 @@ software.")
>                       (setenv "LDFLAGS"
>                               (string-append
>                                "-L" (assoc-ref inputs "boost") "/lib "
> -                              "-lboost_system")))))))
> +                              "-lboost_system"))
> +                     ;; Needed for gtkmm
> +                     (substitute* '("src/wscript_build"
> +                                    "examples/wscript_build")
> +                       (("cxxflags.*= \\[" line)
> +                        (string-append line "\"-std=c++11\", ")))
> +                     #t)))))

Is it not possible to pass this through #:make-flags? If not this LGTM,
but would be nice with a comment about why make-flags won't work.

>      (inputs
>       `(("boost" ,boost)
> +       ("gtkmm" ,gtkmm-2)
>         ("lv2" ,lv2)))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)))
> -- 
> 2.10.2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  parent reply	other threads:[~2016-12-03 21:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-03 19:42 [PATCH 1/2] gnu: lvtk: Build UI library Ricardo Wurmus
2016-12-03 19:42 ` [PATCH 2/2] gnu: Add ams-lv2 Ricardo Wurmus
2016-12-03 21:08   ` Marius Bakke
2016-12-03 22:39     ` Ricardo Wurmus
2016-12-03 21:04 ` Marius Bakke [this message]
2016-12-03 22:32   ` [PATCH 1/2] gnu: lvtk: Build UI library Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2bgbu6r.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.