From: Ricardo Wurmus <rekado@elephly.net>
To: Ra <ilpuccio.febo@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add r-scran 1.2.0 and all its dependencies
Date: Tue, 27 Dec 2016 17:02:44 +0100 [thread overview]
Message-ID: <87k2aljr6j.fsf@elephly.net> (raw)
In-Reply-To: <CACQsWTNkoAAg=u8riwECrb=Ae9cRyHuOE_HUcX=L5NBV4nE2Aw@mail.gmail.com>
Hi Raoul,
> in attachment a patch for the inclusion of an R/Bioconductor library named
> "scran" https://bioconductor.org/packages/release/bioc/html/scran.html ,
> scran has a lot of dependencies and I placed those related to
> bioinformatics/bioconductor into bioinformatics.scm and those related just
> to R insto statistics.scm.
Nice! Thank you for your efforts!
> Let me know if this big-patch is acceptable or how do I need to submit it.
We have a policy of one commit per package. Each commit has a commit
summary in a standard format (you’ll see when running git log).
Going through the big patch I noticed a couple of things:
* the indentation is rather uneven. If you’re using Emacs it’s very
simple to correct this by using TAB and/or hitting C-M-q on the
expression. (Also make sure parentheses are not all by themselves on
an otherwise empty line.)
* line length (especially in descriptions) exceeds the limits.
* Please edit the descriptions. Package descriptions for Guix have to
use full sentences.
Judging from the indentation this doesn’t look like it was created by
the *recursive* importer. Were there any problems using the recursive
CRAN/Bioconductor importer?
The package for “r-shiny” needs a closer look. AFAIR it contains
minified Javascript, which does not count as actual source code. If
that’s in fact the case we would need to fiddle with the package a
little to replace minified Javascript blobs with Javascript source files
(which may be minified as part of the build process). I’d prefer if
“r-shiny” were added to “web.scm”.
In the “r-statmod” package expression the comment above the gfortran
input (which should be a native input) doesn’t seem to apply.
Please also double-check that the licenses are correct. The importer
may not necessary get things right.
Finally, please use lower-case words in the synopsis. In R packages
this is often capitalised.
Could you please send an updated patch set?
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
http://elephly.net
next prev parent reply other threads:[~2016-12-27 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 9:14 [PATCH] Add r-scran 1.2.0 and all its dependencies Ra
2016-12-27 16:02 ` Ricardo Wurmus [this message]
2016-12-27 16:34 ` Ra
2016-12-27 16:59 ` Ricardo Wurmus
2016-12-27 17:06 ` Ra
2016-12-27 21:25 ` Ra
2016-12-28 9:26 ` Ra
2016-12-29 21:52 ` Ricardo Wurmus
2017-01-31 21:47 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2aljr6j.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=ilpuccio.febo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.