Re: [PATCH] gnu: Add opencascade-oce

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 5096 bytes --]


Hello Paul!

Paul Garlick <pgarlick@tourbillion-technology.com> writes:

> * gnu/packages/opencascade.scm: New file
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it

I wonder if this could fit in "engineering.scm". Or maybe "geometry.scm"
or "3d.scm". We try to avoid "single program" modules. What do you think?

> ---
>
> The OpenCASCADE library is used for defining 3D geometry.  It can be
> incorporated as a build option in other packages.  Examples of such packages
> (and the subject domains in which they are used) are Gmsh (mathematics),
> IfcOpenShell (architecture) and FreeCAD (engineering).
>
> There are two versions of OpenCASCADE; the upstream version and the community-
> maintained version.  OCE is the community-maintained version.
>
>  gnu/local.mk                 |  1 +
>  gnu/packages/opencascade.scm | 75 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 76 insertions(+)
>  create mode 100644 gnu/packages/opencascade.scm
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index c6cb55b..c879f32 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -281,6 +281,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/ocr.scm				\
>    %D%/packages/onc-rpc.scm			\
>    %D%/packages/openbox.scm			\
> +  %D%/packages/opencascade.scm			\
>    %D%/packages/openldap.scm			\
>    %D%/packages/openstack.scm			\
>    %D%/packages/orpheus.scm			\
> diff --git a/gnu/packages/opencascade.scm b/gnu/packages/opencascade.scm
> new file mode 100644
> index 0000000..3c4b9b5
> --- /dev/null
> +++ b/gnu/packages/opencascade.scm
> @@ -0,0 +1,75 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2017 Paul Garlick <pgarlick@tourbillion-technology.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages opencascade)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system cmake)
> +  #:use-module (gnu packages)
> +  #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages file)
> +  #:use-module (gnu packages fontutils)
> +  #:use-module (gnu packages gl)
> +  #:use-module (gnu packages python)
> +  #:use-module (gnu packages qt)
> +  #:use-module (gnu packages tcl)
> +  #:use-module (gnu packages xorg))
> +
> +(define-public opencascade-oce
> +  (package
> +    (name "opencascade-oce")
> +    (version "0.17.2")

Version 0.18 was released a few days ago!

> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +               "https://github.com/tpaviot/oce/archive/OCE-"
> +               version
> +               ".tar.gz"))
> +        (sha256
> +          (base32
> +            "0vpmnb0k5y2f7lpmwx9pg9yfq24zjvnsak5alzacncfm1hv9b6cd"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     '(#:configure-flags
> +        (list
> +          (string-append
> +            "-DOCE_INSTALL_PREFIX:PATH=" (assoc-ref %outputs "out"))
> +          "-DOCE_TESTING:BOOL=ON")
> +       #:tests? #t))

#:tests? is #t by default, so that can be omitted. Please also check the
indentation in this section.

> +    (inputs
> +      `(("freetype" ,freetype)
> +        ("ftgl" ,ftgl)
> +        ("glu" ,glu)
> +        ("qt" ,qt)
> +        ("libtool" ,libtool)
> +        ("libxmu" ,libxmu)
> +        ("file" ,file)
> +        ("tk" ,tk)
> +        ("tcl" ,tcl)
> +        ("mesa" ,mesa)))
> +    (native-inputs
> +      `(("python" ,python-wrapper)))
> +    (home-page "http://www.opencascade.org/")

Use HTTPS here.

> +    (synopsis
> +      "Open CASCADE OCE; libraries for 3D modeling and numerical simulation")

No need to put the name in the synopsis :-)

> +    (description "OCE stands for Open CASCADE Community Edition.  The project
> +gathers patches/improvements/experiments contributed by users over the official
> +Open CASCADE library.")
> +    (license license:lgpl2.1))) ; plus header files exception

Please expand on the exception comment and mention
OCCT_LGPL_EXCEPTION.txt. There are also some public domain files, and
the bundled "gtest" is bsd-3. src/OpenGl/OpenGl_glext.h is distributed
under the expat license. Some files generated by "bison" has GPL3+.

Can you send an updated patch? TIA! :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]