From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH -v2 1/2] build: union: Add create-all-directories? parameter to union-build Date: Wed, 08 Mar 2017 18:16:36 +0100 Message-ID: <87k27zlmdn.fsf@gnu.org> References: <20170307110749.31614-1-huang.ying.caritas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clfCd-0006m3-5Q for guix-devel@gnu.org; Wed, 08 Mar 2017 12:16:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clfCZ-0003rK-48 for guix-devel@gnu.org; Wed, 08 Mar 2017 12:16:43 -0500 In-Reply-To: <20170307110749.31614-1-huang.ying.caritas@gmail.com> (Huang Ying's message of "Tue, 7 Mar 2017 19:07:48 +0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Huang Ying Cc: guix-devel@gnu.org Huang Ying skribis: > * guix/build/union.scm (union-build): Add create-all-directories? keyword > parameter. To add/remove some files from the directory. I guess this is needed for fonts.dir, but could you explain why it is? (The explanation could go as a comment above the =E2=80=98union-build=E2=80= =99 call in the second patch.) Other than that LGTM. Thanks, Ludo=E2=80=99.