all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Huang Ying <huang.ying.caritas@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH -v2 1/2] build: union: Add create-all-directories? parameter to union-build
Date: Wed, 08 Mar 2017 18:16:36 +0100	[thread overview]
Message-ID: <87k27zlmdn.fsf@gnu.org> (raw)
In-Reply-To: <20170307110749.31614-1-huang.ying.caritas@gmail.com> (Huang Ying's message of "Tue, 7 Mar 2017 19:07:48 +0800")

Huang Ying <huang.ying.caritas@gmail.com> skribis:

> * guix/build/union.scm (union-build): Add create-all-directories? keyword
>   parameter.  To add/remove some files from the directory.

I guess this is needed for fonts.dir, but could you explain why it is?
(The explanation could go as a comment above the ‘union-build’ call in
the second patch.)

Other than that LGTM.

Thanks,
Ludo’.

  parent reply	other threads:[~2017-03-08 17:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 11:07 [PATCH -v2 1/2] build: union: Add create-all-directories? parameter to union-build Huang Ying
2017-03-07 11:07 ` [PATCH -v2 2/2] guix: profiles: create fonts.dir/scale for all fonts directories Huang Ying
2017-03-07 20:24   ` Danny Milosavljevic
2017-03-08  7:44     ` huang ying
2017-03-08 17:18       ` Ludovic Courtès
2017-03-09 11:42         ` Huang, Ying
2017-03-08 17:24   ` Ludovic Courtès
2017-03-09 11:41     ` Huang, Ying
2017-03-07 20:35 ` [PATCH -v2 1/2] build: union: Add create-all-directories? parameter to union-build Danny Milosavljevic
2017-03-07 20:54   ` Danny Milosavljevic
2017-03-08  7:43   ` huang ying
2017-03-08 17:16 ` Ludovic Courtès [this message]
2017-03-09 11:43   ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k27zlmdn.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=huang.ying.caritas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.