From: Ricardo Wurmus <rekado@elephly.net>
To: Roel Janssen <roel@gnu.org>
Cc: 25928@debbugs.gnu.org
Subject: bug#25928: [PATCH] gnu: Add darktable.
Date: Wed, 10 May 2017 16:40:24 +0200 [thread overview]
Message-ID: <87k25ohj1j.fsf@elephly.net> (raw)
In-Reply-To: <87tw4skdns.fsf@gnu.org>
Roel Janssen <roel@gnu.org> writes:
> From 5053b44b621932d3c3aa0f1ddb8b01dd04cd4680 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Wed, 10 May 2017 16:06:38 +0200
> Subject: [PATCH] gnu: Add darktable.
>
> * gnu/packages/photo.scm (darktable): New variable.
> ---
[…]
> + (arguments
> + `(#:tests? #f ; There are no tests.
> + #:configure-flags '("-DCMAKE_INSTALL_LIBDIR=lib")
> + #:phases
> + (modify-phases %standard-phases
> + (add-before 'configure 'set-ldflags
> + (lambda* (#:key outputs #:allow-other-keys)
> + (setenv "LDFLAGS"
> + (string-append
> + "-Wl,-rpath="
> + (assoc-ref outputs "out") "/lib/darktable"))
> + #t))
> + (add-after 'set-paths 'add-ilmbase-include-path
> + (lambda* (#:key inputs #:allow-other-keys)
> + ;; OpenEXR propagates ilmbase, but its include files do not appear
> + ;; in the CPATH, so we need to add "$ilmbase/include/OpenEXR/" to
> + ;; the CPATH to satisfy the dependency on "ImathInt64.h".
> + (setenv "CPATH"
> + (string-append
> + (assoc-ref inputs "ilmbase")
> + "/include/OpenEXR:" (or (getenv "CPATH") "")))
> + #t)))))
I wonder if it would be possible to augment LDFLAGS and CPATH in
#:configure-flags or #:make-flags instead of using build phases (which I
find a bit crude).
If that’s too hard I promise I won’t complain about doing it with build
phases :)
> + (native-inputs
> + `(("llvm" ,llvm-3.9.1)
> + ("clang" ,clang-3.9.1)))
> + (inputs
> + `(("libxslt" ,libxslt)
> + ("libxml2" ,libxml2)
> + ("pugixml" ,pugixml)
> + ("gtk+" ,gtk+)
> + ("sqlite" ,sqlite)
> + ("libjpeg" ,libjpeg)
> + ("libpng" ,libpng)
> + ("cairo" ,cairo)
> + ("lcms" ,lcms)
> + ("exiv2" ,exiv2)
> + ("libtiff" ,libtiff)
> + ("curl" ,curl)
> + ("libgphoto2" ,libgphoto2)
> + ("dbus-glib" ,dbus-glib)
> + ("openexr" ,openexr)
> + ("ilmbase" ,ilmbase)
> + ("libsoup" ,libsoup)
> + ("python-jsonschema" ,python-jsonschema)
> + ("intltool" ,intltool)
> + ("perl" ,perl)
> + ("pkg-config" ,pkg-config)
> + ("libwebp" ,libwebp)
> + ("lensfun" ,lensfun)
> + ("librsvg" ,librsvg)
> + ("json-glib" ,json-glib)
> + ("freeimage" ,freeimage)))
> + (home-page "https://www.darktable.org")
> + (synopsis "Virtual lighttable and darkroom for photographers")
> + (description "Darktable is an open source photography workflow
> application
s/an open source/a/
> +and RAW developer. It manages your digital negatives in a database, lets you
> +view them through a zoomable lighttable and enables you to develop raw images
> +and enhance them.")
> + (license license:gpl3+)))
Good to push with the change to the description.
Thanks!
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
next prev parent reply other threads:[~2017-05-10 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87zih4ee7i.fsf@gnu.org>
[not found] ` <20170313232428.0530762b@alma-ubu>
[not found] ` <20170314231326.3ac43a08@alma-ubu>
2017-03-30 13:19 ` bug#25928: [PATCH] gnu: Add darktable Ricardo Wurmus
2017-03-30 13:00 ` Roel Janssen
2017-05-10 14:08 ` Roel Janssen
2017-05-10 14:40 ` Ricardo Wurmus [this message]
2017-05-10 15:28 ` Roel Janssen
2017-05-10 16:06 ` Ricardo Wurmus
2017-05-10 17:51 ` Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k25ohj1j.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=25928@debbugs.gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.