From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54678)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8VmQ-0003Fd-3J
	for guix-patches@gnu.org; Wed, 10 May 2017 13:52:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8VmM-0004up-93
	for guix-patches@gnu.org; Wed, 10 May 2017 13:52:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34351)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d8VmM-0004uW-5d
	for guix-patches@gnu.org; Wed, 10 May 2017 13:52:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8VmL-0001Sz-VA
	for guix-patches@gnu.org; Wed, 10 May 2017 13:52:01 -0400
Subject: bug#25928: [PATCH] gnu: Add darktable.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.25928.D25928.14944387205625.done@debbugs.gnu.org>
References: <87zih4ee7i.fsf@gnu.org> <20170313232428.0530762b@alma-ubu>
	<20170314231326.3ac43a08@alma-ubu> <87fuhu52c8.fsf@elephly.net>
	<87tw4skdns.fsf@gnu.org> <87k25ohj1j.fsf@elephly.net>
	<87shkck9ye.fsf@gnu.org> <87d1bghf1z.fsf@elephly.net>
From: Roel Janssen <roel@gnu.org>
Message-ID: <87k25obnxm.fsf@gnu.org>
In-reply-to: <87d1bghf1z.fsf@elephly.net>
Date: Wed, 10 May 2017 19:51:42 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 25928-done@debbugs.gnu.org


Ricardo Wurmus writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> > I wonder if it would be possible to augment LDFLAGS and CPATH in
>> > #:configure-flags or #:make-flags instead of using build phases (which I
>> > find a bit crude).
>> >
>> > If that’s too hard I promise I won’t complain about doing it with build
>> > phases :)
>
>> See attached patch.  By adding the LDFLAGS part to either #:make-flags
>> or #:configure-flags, the run-path validation phase fails at the end of
>> the build process.
>
>> So, maybe we can settle half-way here? :-)
>
> Sure, looks good to me!
>
>> > Good to push with the change to the description.
>> > Thanks!
>
>> Is this then finally the moment we get to have darktable in Guix? :-)
>
> Yay!  Thank you!

Pushed in 91a9c65c7bae73d999ccc2288833e909ce4a0871.

Thanks!

Kind regards,
Roel Janssen