From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dd0JK-0007kS-SK for guix-patches@gnu.org; Wed, 02 Aug 2017 16:32:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dd0JG-0002eA-Qe for guix-patches@gnu.org; Wed, 02 Aug 2017 16:32:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36269) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dd0JG-0002e0-MR for guix-patches@gnu.org; Wed, 02 Aug 2017 16:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dd0JG-0000bd-9g for guix-patches@gnu.org; Wed, 02 Aug 2017 16:32:02 -0400 Subject: [bug#27898] [PATCH 2/2] gnu: Put autoconf-related phases immediately after the 'unpack phase. Resent-Message-ID: From: Kei Kebreau References: <20170801072153.19077-1-kei@openmailbox.org> <20170801072153.19077-2-kei@openmailbox.org> <87k22lwys2.fsf@fastmail.com> <20170802194515.GC13105@jasmine.lan> Date: Wed, 02 Aug 2017 16:31:08 -0400 In-Reply-To: <20170802194515.GC13105@jasmine.lan> (Leo Famulari's message of "Wed, 2 Aug 2017 15:45:15 -0400") Message-ID: <87k22l4sqb.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 27898@debbugs.gnu.org --=-=-= Content-Type: text/plain Leo Famulari writes: > On Wed, Aug 02, 2017 at 09:33:01PM +0200, Marius Bakke wrote: >> Kei Kebreau writes: > > [... move autoconf phases ...] > >> Phew! This too will cause a lot of rebuilds, but I guess we could put it >> on 'staging'. It would have to be committed just before starting it to >> reduce the amount of merge conflicts. > > Agreed > >> That said, I'm not sure how necessary this change is, but I don't have a >> strong argument against it. Other opinions welcome! > > I guess there is a correct ordering and an incorrect ordering, depending > on whether or not these phases should happen before or after the shebang > patching phases. Does it work if it happens before the shebangs are > patched? > What does the "it" in "does it work" mean here? If you mean the builds themselves, then no. Success isn't guaranteed because the configure scripts might not be patched, as the patching phases are finished before the "build" phases. This change ensures that the "patch-usr-bin-file" phase can operate on generated configure scripts if necessary: https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00124.html >> Maybe we could add an '#:autoreconf?' parameter to gnu-build-system, >> which runs `autoreconf -vif` in a phase and automatically pulls in >> automake and autoconf (and probably also libtool). Thoughts? > > Interesting! I agree. It would cut down on repetitive, common code and potential for "autoreconf-ing" incorrectly. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlmCNowACgkQ5qXuPBlG eg2QOw/9Hf6PV2ZIZa+r2fzbhx4xFKEyJAPG21/YtL6rEsLze3Mdm+AFFHQ+6Lkr 96mdBi3Xqz68aINITUiCtqwmx4kf428E0ntz4k2U2eAXzDnfswQxLVjKxjRaxJl8 zfG3TAklZdJr4dhm5oatJK6Lp+4SG+/5/T041vPRNWGkHoW4Qek8KARltkILxpAr FfJwHwhikId8749f7Gnz54h1o4W+/waPg1st+AcHf7y9XVI/fHJxccJUcGfWne2S nIFFs08yy7krqE89oWauH3xD0Ya3JHZjFlBCoJs5FOSupyY2eXB7lv4HlSeRMjH+ 3ZxXUIcv4lGqdoP23G7mxVe+cNxWFnimp5GJbwIpWsSF5nuuHrzaAcV2sAPS5m3T YNSvO7r9OCIoezvC4O7ICuWYRnGgsA2C0dHcCEAq12lHEQheItFvDSOemN6EbkzL omjEWKX3da4AzHS4Fy444wvwdcYdkKQm2JVBrmgoc+Rrj25xt2uk8+Q967f3hsd0 2vbh6/HlcH6YkSHrXvw0sAc8SeiC0HHaiJ2BiQ3JzgzsVtvbwTmasoL1i9tlBeR4 Bi7iPpAGb16oe65K196oiEFXL6INvkiEMvtIokGwda67vWoc0WAehcj7acAKx9uh gpjxRe2TJx7Et94Kotb2TdwkQXcRDTm74D02fDe8qWJAjxNL4mE= =tmXp -----END PGP SIGNATURE----- --=-=-=--