[bug#28190] [PATCH] gnu: Build the shared library for yaml-cpp.

[bug#28190] [PATCH] gnu: Build the shared library for yaml-cpp.

[Christopher Baines]

* gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
  -DBUILD_SHARED_LIBS=ON to #:configure-flags.
---
 gnu/packages/serialization.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index 3994191bd..8032e3181 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -249,6 +249,8 @@ that implements both the msgpack and msgpack-rpc specifications.")
                (base32
                 "1vk6pjh0f5k6jwk2sszb9z5169whmiha9ainbdpa1arxlkq7v3b6"))))
     (build-system cmake-build-system)
+    (arguments
+     '(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")))
     (inputs
      `(("boost" ,boost)))
     (native-inputs
-- 
2.14.1

[bug#28190] [PATCH] gnu: Build the shared library for yaml-cpp.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

Christopher Baines <mail@cbaines.net> writes:

> * gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
>   -DBUILD_SHARED_LIBS=ON to #:configure-flags.

Does this disable building the static library too?  If not, should we do
that while at it?  LGTM, anyway.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#28190] [PATCH] gnu: Build the shared library for yaml-cpp.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

On Tue, 22 Aug 2017 22:58:34 +0200
Marius Bakke <mbakke@fastmail.com> wrote:

> Christopher Baines <mail@cbaines.net> writes:
> 
> > * gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
> >   -DBUILD_SHARED_LIBS=ON to #:configure-flags.  
> 
> Does this disable building the static library too?  If not, should we
> do that while at it?  LGTM, anyway.

I'm not quite sure, but I think so, these are the files in lib now, and
the .a file that was there before has disappeared.

└── lib
    ├── libyaml-cpp.so -> libyaml-cpp.so.0.5
    ├── libyaml-cpp.so.0.5 -> libyaml-cpp.so.0.5.3
    ├── libyaml-cpp.so.0.5.3
    └── pkgconfig
        └── yaml-cpp.pc



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

[bug#28190] [PATCH] gnu: Build the shared library for yaml-cpp.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

Christopher Baines <mail@cbaines.net> writes:

> On Tue, 22 Aug 2017 22:58:34 +0200
> Marius Bakke <mbakke@fastmail.com> wrote:
>
>> Christopher Baines <mail@cbaines.net> writes:
>> 
>> > * gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
>> >   -DBUILD_SHARED_LIBS=ON to #:configure-flags.  
>> 
>> Does this disable building the static library too?  If not, should we
>> do that while at it?  LGTM, anyway.
>
> I'm not quite sure, but I think so, these are the files in lib now, and
> the .a file that was there before has disappeared.
>
> └── lib
>     ├── libyaml-cpp.so -> libyaml-cpp.so.0.5
>     ├── libyaml-cpp.so.0.5 -> libyaml-cpp.so.0.5.3
>     ├── libyaml-cpp.so.0.5.3
>     └── pkgconfig
>         └── yaml-cpp.pc

Great!  Static libraries cannot be reliably grafted, so it's good to
avoid them when we can.  Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#28190: [PATCH] gnu: Build the shared library for yaml-cpp.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

On Tue, 22 Aug 2017 23:10:38 +0200
Marius Bakke <mbakke@fastmail.com> wrote:

> Christopher Baines <mail@cbaines.net> writes:
> 
> > On Tue, 22 Aug 2017 22:58:34 +0200
> > Marius Bakke <mbakke@fastmail.com> wrote:
> >  
> >> Christopher Baines <mail@cbaines.net> writes:
> >>   
> >> > * gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
> >> >   -DBUILD_SHARED_LIBS=ON to #:configure-flags.    
> >> 
> >> Does this disable building the static library too?  If not, should
> >> we do that while at it?  LGTM, anyway.  
> >
> > I'm not quite sure, but I think so, these are the files in lib now,
> > and the .a file that was there before has disappeared.
> >
> > └── lib
> >     ├── libyaml-cpp.so -> libyaml-cpp.so.0.5
> >     ├── libyaml-cpp.so.0.5 -> libyaml-cpp.so.0.5.3
> >     ├── libyaml-cpp.so.0.5.3
> >     └── pkgconfig
> >         └── yaml-cpp.pc  
> 
> Great!  Static libraries cannot be reliably grafted, so it's good to
> avoid them when we can.  Thanks!

I've pushed this now, thanks for your review Marius :)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]