From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#28966: git fails test suite Date: Wed, 01 Nov 2017 21:22:44 +0100 Message-ID: <87k1z94uln.fsf@fastmail.com> References: Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9zXV-0001qi-CZ for bug-guix@gnu.org; Wed, 01 Nov 2017 16:23:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9zXS-0000BG-82 for bug-guix@gnu.org; Wed, 01 Nov 2017 16:23:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:37787) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9zXR-0000Az-Tv for bug-guix@gnu.org; Wed, 01 Nov 2017 16:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e9zXR-0000an-Lo for bug-guix@gnu.org; Wed, 01 Nov 2017 16:23:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ricardo Wurmus , 28966@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ricardo Wurmus writes: > As of 62d48234e20c732ebefc1b4deb425f590b4241ca git fails at least one of > its tests on my servers: > > --8<---------------cut here---------------start------------->8--- > not ok 185 - --contains and --no-contains work in a deep repo > # > # >expect && > # i=3D1 && > # while test $i -lt 8000 > # do > # echo "commit refs/heads/master > # committer A U Thor $((1000000000 + $i * 100)= ) +0200 > # data < # commit #$i > # EOF" > # test $i =3D 1 && echo "from refs/heads/master^0" > # i=3D$(($i + 1)) > # done | git fast-import && > # git checkout master && > # git tag far-far-away HEAD^ && > # run_with_limited_stack git tag --contains HEAD >actual && > # test_cmp expect actual && > # run_with_limited_stack git tag --no-contains HEAD >actual= && > # test_line_count "-gt" 10 actual > # > --8<---------------cut here---------------end--------------->8--- > > The server has 1.5TB RAM and 192 cores. I=E2=80=99ve tried to build git = about 5 > times; some of these times I used =E2=80=9C--cores=3D1=E2=80=9D to force = a sequential > build, but the tests would still fail. I wonder if this has anything to do with the fact that this test (and one other) limits the stack size to 128 kB (ulimit -s). FWIW here is the commit that added this test: https://github.com/git/git/commit/cbc60b67201e083a4970c8731c5382a575357e36 It has since been increased from 64kB to 128kB, so I wonder if the attached patch will make any difference. Can you try it? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-git-Increase-stack-size-for-tests.patch Content-Transfer-Encoding: quoted-printable From=20f95ae3d32e5eab9797cb1591cca07c4d31f187ab Mon Sep 17 00:00:00 2001 From: Marius Bakke Date: Wed, 1 Nov 2017 21:11:29 +0100 Subject: [PATCH] gnu: git: Increase stack size for tests. * gnu/packages/version-control.scm (git)[arguments]: Add substitution in 'patch-tests' phase. =2D-- gnu/packages/version-control.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-contro= l.scm index af880c29f..9059284ed 100644 =2D-- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -216,6 +216,12 @@ as well as the classic centralized workflow.") ;; Many tests contain inline shell scripts (hooks etc). (substitute* (find-files "t" "\\.sh$") (("#!/bin/sh") (string-append "#!" (which "sh")))) + ;; XXX: Some tests run with a limited stack size, but it may + ;; be too small for very large machines (1TB+). See + ;; . + (substitute* "t/test-lib.sh" + (("\\(ulimit -s 128") + "(ulimit -s 256")) ;; Un-do shebang patching here to prevent checksum mismatch. (substitute* '("t/t4034/perl/pre" "t/t4034/perl/post") (("^#!.*/bin/perl") "#!/usr/bin/perl")) =2D-=20 2.14.3 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAln6LRQACgkQoqBt8qM6 VPrdCQgAk20iSEXl/dl6rVSvrS9OLuQ+HIz95zE09bZrwmZq4O1gh1/uXJ5LmJfq cAydn1EjtmGuKdrtKDuSv/YttoOqCSQiwc0GiFp6tsrmniR4t25CuDh8EWiqe+i1 cVlJw6fSLYqhOJQAh6PGWGKXCE60Spl4/MB0kwOOnGFMHPK8vnBJhi8natnuKpd/ NE94DUjOm/S2vddZ1bDERIUsDfwUG9scc36k3GkFr7lwnprZ5LRoEeu5GVhJzTcI i3Ic6n9w2O1H/n/x2oAbYX1lo5APxI6IpTHO83npesNJibVy6dCXPH5ul3YYn170 3Qu8M7DcU7ZbcM3657gMNPZ5/Kncyg== =CkCk -----END PGP SIGNATURE----- --==-=-=--