* bug#30024: [PATCH] core-updates: librsvg: Disable more failing tests
@ 2018-01-08 7:08 Mark H Weaver
2018-01-08 14:13 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Mark H Weaver @ 2018-01-08 7:08 UTC (permalink / raw)
To: 30024
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On the core-updates branch, in librsvg, some tests fail on i686 and
armhf. I've attached a proposed patch, but I haven't yet been able to
test it because I no longer use binary substitutes on my systems and I'm
currently having some difficulties[*] building the base packages.
If someone else would like to test this and push it to core-updates, I'd
be grateful. It would be sufficient to test on i686, I think.
Mark
[*] GNU tar's handling of sparse files is broken on btrfs filesystems
and thus fails its test suite on my system, and the test suite of
guile-2.2.3 hung up (no output or CPU usage for 30 minutes with a
defunct guile process) on my x86_64 GuixSD system.
[-- Attachment #2: [PATCH] UNTESTED: gnu: librsvg: Disable more failing tests --]
[-- Type: text/x-patch, Size: 2533 bytes --]
From e414375109364f29618ec8e71074e71f514d1765 Mon Sep 17 00:00:00 2001
From: Mark H Weaver <mhw@netris.org>
Date: Sun, 7 Jan 2018 21:35:35 -0500
Subject: [PATCH] UNTESTED: gnu: librsvg: Disable more failing tests.
* gnu/packages/gnome.scm (librsvg)[arguments]: Rename
'remove-failing-test' phase to 'remove-failing-tests'. Disable more
tests that fail on i686 and armhf.
---
gnu/packages/gnome.scm | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 6d907fdf9..e5345b111 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -9,7 +9,7 @@
;;; Copyright © 2015, 2017 Andy Wingo <wingo@igalia.com>
;;; Copyright © 2015 David Hashe <david.hashe@dhashe.com>
;;; Copyright © 2015, 2016, 2017 Ricardo Wurmus <rekado@elephly.net>
-;;; Copyright © 2015, 2016, 2017 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2015, 2016, 2017, 2018 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2015 David Thompson <davet@gnu.org>
;;; Copyright © 2015, 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2016, 2017 Rene Saavedra <rennes@openmailbox.org>
@@ -1207,11 +1207,19 @@ dealing with different structured file formats.")
(("gdk_pixbuf_cache_file = .*$")
"gdk_pixbuf_cache_file = $(TMPDIR)/loaders.cache\n"))
#t))
- (add-after 'unpack 'remove-failing-test
- ;; This test fails on aarch64.
+ (add-after 'unpack 'remove-failing-tests
(lambda _
- (delete-file "tests/fixtures/reftests/bugs/777834-empty-text-children.svg")
- (delete-file "tests/fixtures/reftests/bugs/777834-empty-text-children-ref.png")
+ (with-directory-excursion "tests/fixtures/reftests"
+ (for-each delete-file
+ '(;; This test fails on i686:
+ "svg1.1/masking-path-04-b.svg"
+ "svg1.1/masking-path-04-b-ref.png"
+ ;; This test fails on armhf:
+ "svg1.1/masking-mask-01-b.svg"
+ "svg1.1/masking-mask-01-b-ref.png"
+ ;; This test fails on aarch64:
+ "bugs/777834-empty-text-children.svg"
+ "bugs/777834-empty-text-children-ref.png")))
#t)))))
(native-inputs
`(("pkg-config" ,pkg-config)
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#30024: [PATCH] core-updates: librsvg: Disable more failing tests
2018-01-08 7:08 bug#30024: [PATCH] core-updates: librsvg: Disable more failing tests Mark H Weaver
@ 2018-01-08 14:13 ` Ludovic Courtès
2018-01-08 16:50 ` Mark H Weaver
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2018-01-08 14:13 UTC (permalink / raw)
To: Mark H Weaver; +Cc: 30024-done
Hello,
Mark H Weaver <mhw@netris.org> skribis:
> On the core-updates branch, in librsvg, some tests fail on i686 and
> armhf. I've attached a proposed patch, but I haven't yet been able to
> test it because I no longer use binary substitutes on my systems and I'm
> currently having some difficulties[*] building the base packages.
>
> If someone else would like to test this and push it to core-updates, I'd
> be grateful. It would be sufficient to test on i686, I think.
Tested on i686 and pushed, thank you!
> [*] GNU tar's handling of sparse files is broken on btrfs filesystems
> and thus fails its test suite on my system, and the test suite of
> guile-2.2.3 hung up (no output or CPU usage for 30 minutes with a
> defunct guile process) on my x86_64 GuixSD system.
Many file system related tests fail on Btrfs. :-/
As for the Guile failure, it’s weird. Could you gather more info if it
happens again?
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#30024: [PATCH] core-updates: librsvg: Disable more failing tests
2018-01-08 14:13 ` Ludovic Courtès
@ 2018-01-08 16:50 ` Mark H Weaver
0 siblings, 0 replies; 3+ messages in thread
From: Mark H Weaver @ 2018-01-08 16:50 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 30024-done
Hi Ludovic,
ludo@gnu.org (Ludovic Courtès) writes:
> Mark H Weaver <mhw@netris.org> skribis:
>
>> [*] GNU tar's handling of sparse files is broken on btrfs filesystems
>> and thus fails its test suite on my system, and the test suite of
>> guile-2.2.3 hung up (no output or CPU usage for 30 minutes with a
>> defunct guile process) on my x86_64 GuixSD system.
>
> Many file system related tests fail on Btrfs. :-/
I've resumed an old discussion about the GNU Tar issue here:
https://lists.gnu.org/archive/html/bug-tar/2018-01/msg00002.html
The good news is that Paul Eggert, a GNU Tar maintainer, is open to
letting me fix this bug properly.
> As for the Guile failure, it’s weird. Could you gather more info if it
> happens again?
I just filed a report with the information I gathered, here:
https://bugs.gnu.org/30027
I neglected to mention it, but I also saved the failed build directory,
and the complete build log.
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-08 16:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-08 7:08 bug#30024: [PATCH] core-updates: librsvg: Disable more failing tests Mark H Weaver
2018-01-08 14:13 ` Ludovic Courtès
2018-01-08 16:50 ` Mark H Weaver
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.