From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eenXC-0006zd-R9 for guix-patches@gnu.org; Thu, 25 Jan 2018 14:50:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eenX8-0005NY-TW for guix-patches@gnu.org; Thu, 25 Jan 2018 14:50:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:34960) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eenX8-0005NP-Pv for guix-patches@gnu.org; Thu, 25 Jan 2018 14:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eenX8-0008Fi-Fg for guix-patches@gnu.org; Thu, 25 Jan 2018 14:50:02 -0500 Subject: [bug#29536] [PATCH] gnu: Add cava. In-Reply-To: <87efocor8u.fsf@gmail.com> Resent-Message-ID: From: Oleg Pykhalov References: <87efocor8u.fsf@gmail.com> <20171202220708.cg6xnqca7ovul5ng@abyayala> <87wp24uux2.fsf@gmail.com> <87o9lph0fh.fsf@gnu.org> Date: Thu, 25 Jan 2018 22:49:07 +0300 Message-ID: <87k1w5hg7g.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 29536@debbugs.gnu.org, 29536-done@debbugs.gnu.org, ng0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Ludovic, Thank you for review! ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>>>>From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001 >> From: Oleg Pykhalov >> Date: Sat, 2 Dec 2017 22:36:36 +0300 >> Subject: [PATCH] gnu: Add cava. >> >> * gnu/packages/audio.scm (cava): New variable. > > [...] > >> + (modify-phases %standard-phases >> + (add-after 'unpack 'bootstrap >> + (lambda _ >> + (setenv "HOME" (getcwd)) >> + (zero? (system* "sh" "autogen.sh")))) > > Please use =E2=80=98invoke=E2=80=99 instead of =E2=80=98system*=E2=80=99. This is new. OK, will use. Thank you for notice! >> + (add-before 'build 'make-cava-ldflags >> + (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out")= "/lib")))) > > Please use: > > (lambda* (#:key outputs #:allow-other-keys) > =E2=80=A6 outputs =E2=80=A6) Should be this? (lambda* (#:key outputs #:allow-other-keys) =E2=80=A6 (assoc-ref outputs "out") =E2=80=A6) >> + (add-after 'install 'data >> + (lambda _ (for-each (lambda (file) >> + (install-file file (string-append >> + (assoc-ref %outputs "ou= t") >> + "/share/doc/examples"))) >> + (find-files "example_files"))))))) > Likewise. OK. >> + (home-page "https://karlstav.github.io/cava/") >> + (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio") > > Rather: =E2=80=9CConsole audio visualizer for ALSA, MPD, and PulseAudio= =E2=80=9D. OK. >> + (description "@code{cava} provides a command line audio visualizer = for >> +MPD, Alsa and Pulseaudio.") > > Based on their README: > > C.A.V.A. is a bar audio spectrum visualizer for the terminal using > ALSA, MPD, PulseAudio, or a FIFO buffer as its input. OK. > OK with these changes, thank you! Pushed as c2c0d66162152b05fc42fdd1be5f07b9eca3bc66 Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlpqNLMACgkQckbhHGm3 lWmvdxAAj06PaWR9Cb+juqLoEcfkJcweKQh/HPdBS9UZi68Uu4aXSIYtl+7tWWMk a8j1QJebFVUZnbOmo2uyMbQZzCKdvRPhRtSB/mWmL1EsODTx3Rc3NPJv9il/Zcxe JUv88okmNqdlm48FXsBK3tMjZqekAVwauj8jbliz5DfoCteTXSE9aqt2tb3kM0Yk q8qbcTJpK7sOmrzMBOPZisOyWd7id8p7xL+yADfuV5ydEjFKTqCke2w0HGRiSDPB U7GEZcqo4zc8anx6aaPh2eBunXHwKeO/i5iBotSQcvhxNOCmCiFqBqwDdWYiOZlh 97RLvi0G+5M7tzkZ8X5fuEmBfAKBdAp2CGRng/RixhVoR6uRuRQ5zREMpXU2nZxW su1eH/wx0tzAzL5tYwYhj/3qmCPORTR1dfwEuwBySZFlFTDzEf9MLQKwjunlBorh DVAjqKwSkCvM8uDwsv6geIU46VN+6bYGJTFtkswAcRvyhPk/bKvQIy853CzHt5Ws b9IDkGc2jE9fJpazzX0TeCA2kvQJ2AhXbqf+t5BS1XLpbGpxf5Xbs8xeUjaM4n9r WWKlSXdsQPYIdI/PLe3ojxTY33YZmEsWDzfOqXdc5q6Rrtrf+broEdxEVBikI3oE yaRDnX9xRmNUxL+qLPyAcVmHqIejWRjcDex8jUnN82svygLjpeA= =2hEY -----END PGP SIGNATURE----- --=-=-=--