From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evO0g-0002QH-6i for guix-patches@gnu.org; Mon, 12 Mar 2018 10:01:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evO0c-0006mh-9l for guix-patches@gnu.org; Mon, 12 Mar 2018 10:01:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49121) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evO0c-0006lJ-66 for guix-patches@gnu.org; Mon, 12 Mar 2018 10:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1evO0b-0008Jw-UH for guix-patches@gnu.org; Mon, 12 Mar 2018 10:01:01 -0400 Subject: [bug#30761] [PATCH staging 1/9] gnu: meson: Don't wrap the meson executable. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180309180914.22752-1-mbakke@fastmail.com> <20180309181108.22888-1-mbakke@fastmail.com> <87vae2tfxy.fsf@gnu.org> <876061jw9o.fsf@fastmail.com> Date: Mon, 12 Mar 2018 15:00:34 +0100 In-Reply-To: <876061jw9o.fsf@fastmail.com> (Marius Bakke's message of "Mon, 12 Mar 2018 13:47:31 +0100") Message-ID: <87k1uhpf5p.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 30761@debbugs.gnu.org Marius Bakke skribis: > Ludovic Court=C3=A8s writes: > >> Hello! >> >> Marius Bakke skribis: >> >>> * gnu/packages/build-tools.scm (meson)[arguments]: Delete WRAP-PHASE. >>> --- >>> gnu/packages/build-tools.scm | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm >>> index 2abb44fdb..1ebccca43 100644 >>> --- a/gnu/packages/build-tools.scm >>> +++ b/gnu/packages/build-tools.scm >>> @@ -81,6 +81,11 @@ makes a few sacrifices to acquire fast full and incr= emental build times.") >>> (base32 >>> "06r8limj38mv884s5riiz6lpzw37cvhbf9jd0smzcbi7fwmv3yah"= )))) >>> (build-system python-build-system) >>> + (arguments >>> + `(#:phases (modify-phases %standard-phases >>> + ;; Meson runs itself through the Python interpreter,= so >>> + ;; we cannot use the shell wrapper. >>> + (delete 'wrap)))) >> >> I=E2=80=99m not sure what this means. The =E2=80=98wrap=E2=80=99 phase = is precisely for things >> with #!/=E2=80=A6/python, right? >> >> What problem does it solve? > > The problem is that at some point after 0.42 (the current > meson-for-build), Meson does the equivalent of `python $(which meson)` > at runtime. Which ends up tripping over the shell wrapper. > > I don't remember exactly where I saw the problem, it could have been > with "mesontest" which also resides in "meson/bin". The only downside > to deleting the wrapper is that you cannot call meson directly from the > store; it works fine as long as PYTHONPATH is set (e.g. in a profile). > > I'll try to clarify the comment. Yes, that=E2=80=99s a good idea. :-) It does mean that people installing meson in their profile will get something missing-python-module errors, right? Should we do the wrapping differently? Thanks, Ludo=E2=80=99.