From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Proposed environment variable to skip running tests
Date: Sun, 22 Apr 2018 22:09:19 +0200
Message-ID: <87k1szgg0g.fsf@gnu.org>
References: <5b415e2dbca38a354b20de465f842243@airmail.cc>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1fALIe-0006pg-8R
	for guix-devel@gnu.org; Sun, 22 Apr 2018 16:09:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1fALIZ-0008JO-86
	for guix-devel@gnu.org; Sun, 22 Apr 2018 16:09:28 -0400
Received: from hera.aquilenet.fr ([185.233.100.1]:44716)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ludo@gnu.org>) id 1fALIZ-0008Ix-2P
	for guix-devel@gnu.org; Sun, 22 Apr 2018 16:09:23 -0400
In-Reply-To: <5b415e2dbca38a354b20de465f842243@airmail.cc> (rain1@airmail.cc's
	message of "Sun, 22 Apr 2018 16:26:41 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: rain1@airmail.cc
Cc: guix-devel@gnu.org

Hello,

rain1@airmail.cc skribis:

> I would like to propose an environment variable that can be used to
> skip tests, e.g. export GUIX_SKIP_TESTS=3D1
>
> This could be implemented by changing line 297 of
> guix/guix/build/gnu-build-system.scm:
>
> (define* (check #:key target (make-flags '()) (tests? (not target))
>                 (test-target "check") (parallel-tests? #t)
>                 #:allow-other-keys)
>   (if (and tests? (not (getenv "GUIX_SKIP_TESTS"))) ;;;;;; HERE

Since builds are performed in an isolated environments with a clearly
defined set of environment variables.  Thus what you define would not
work as-is.

To achieve it, we=E2=80=99d have to, for instance, instruct guix-daemon to
special-case =E2=80=98GUIX_SKIP_TESTS=E2=80=99 and let it through in the bu=
ild
environment.

Even though I can imagine the pain you feel while rebuilding everything
on GNU/Hurd, I=E2=80=99m reluctant to such changes.  I would suggest using
tricks to avoid full rebuilds in your case as much as possible.  (If you
provide concrete examples of rebuilds you=E2=80=99d like to avoid, I can pe=
rhaps
illustrate what =E2=80=9Ctricks=E2=80=9D you could use.  :-))

Thanks,
Ludo=E2=80=99.