From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#31786: 'pre-inst-env guix --version' is not updated by new
	commits"
Date: Tue, 12 Jun 2018 15:21:41 +0200
Message-ID: <87k1r4p2ca.fsf@gnu.org>
References: <87r2lddwyg.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60549)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fSjFQ-0001Zt-IM
	for bug-guix@gnu.org; Tue, 12 Jun 2018 09:22:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fSjFK-0001co-J9
	for bug-guix@gnu.org; Tue, 12 Jun 2018 09:22:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:36370)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fSjFK-0001cA-D4
	for bug-guix@gnu.org; Tue, 12 Jun 2018 09:22:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fSjFJ-0006Ve-Mb
	for bug-guix@gnu.org; Tue, 12 Jun 2018 09:22:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.31786.B31786.152880971925014@debbugs.gnu.org>
In-Reply-To: <87r2lddwyg.fsf@gmail.com> (George Clemmer's message of "Mon, 11
	Jun 2018 14:01:11 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: George Clemmer <myglc2@gmail.com>
Cc: 31786@debbugs.gnu.org

Hello George,

George Clemmer <myglc2@gmail.com> skribis:

> But with subsequent git commit/make cycles the version does not
> change. It doesn't change when the guix package is updated either. For
> example, after pulling and building the recent commit updating the guix
> package ...

Currently the version number is hardcoded in =E2=80=98configure.ac=E2=80=99=
, so the fact
that running =E2=80=9Cgit pull && make=E2=80=9D doesn=E2=80=99t change it i=
s expected.  So to
me, it=E2=80=99s not a bug.

We could improve on that (see for instance how Guile does it with
build-aux/git-version-gen), but it still won=E2=80=99t be updated at each c=
ommit
because that=E2=80=99d be inconvenient: =E2=80=98config.h=E2=80=99 would re=
generated, so in turn
we=E2=80=99d need to rebuild all of the C++ code.

=E2=80=98guix pull=E2=80=99 does the right thing though, which I think is m=
ore important
than the build tree.

> Side questions:
>
> 1) why don't you gitignore "doc/stamp-1"?

Good idea, done!  :-)

> 2) why don't you gitignore .po files?

Because they are checked in.

Thanks for your report.

Ludo=E2=80=99.