From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: Next steps Date: Mon, 25 Jun 2018 22:28:09 +0200 Message-ID: <87k1qmmx0m.fsf@elephly.net> References: <8ea5d026-fab9-7b12-198e-610ad7743cb2@swecha.net> <02e1a59a-ebc1-dfce-e1d6-22e97e742214@swecha.net> <874lifypeb.fsf@elephly.net> <648f81fc-0607-2c3b-f9a3-ca3b29cd637b@swecha.net> <87bmck22uz.fsf@elephly.net> <8736xv1xvq.fsf@elephly.net> <64dfaf0c-3bcf-7b76-5831-b1c41d3f5563@swecha.net> <877en4ccut.fsf@elephly.net> <2b03fcec-c2d8-0604-156c-70fe7643a6cb@swecha.net> <87zhzzbqn6.fsf@elephly.net> <8f509759-c798-a150-bf5a-9b13cd07ac5b@swecha.net> <87lgbibir5.fsf@elephly.net> <564233bd-9511-7f84-3350-6a3a905534a8@swecha.net> <87r2l767sg.fsf@elephly.net> <874lhwtn5a.fsf@elephly.net> <204a32d1-f216-dedd-2234-cd05e3d406a9@swecha.net> <4b5ce9b0-a2d1-30e3-489b-a0028d227c5c@swecha.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXY70-00047O-CH for guix-devel@gnu.org; Mon, 25 Jun 2018 16:29:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXY6y-00059W-7h for guix-devel@gnu.org; Mon, 25 Jun 2018 16:29:22 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21047) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fXY6x-000596-Vs for guix-devel@gnu.org; Mon, 25 Jun 2018 16:29:20 -0400 In-reply-to: <4b5ce9b0-a2d1-30e3-489b-a0028d227c5c@swecha.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Sahithi Yarlagadda Cc: guix-devel Hi Sahithi, > I think I am done with basic changes for 4th task. File is attached. As > mentioned in IRC output is in escape code sequence when I tried in REPL. Great. Please change ui.scm directly and send a patch that can be applied to the wip-sahithi branch. Please also pay attention to these things: * indent the lines properly (Emacs does the right thing when you hit TAB) * don=E2=80=99t leave extraneous comments or dead code * make sure long expressions are broken up >> I am done with 2nd task out of given 4 tasks and that was included in my >> previous patch. >> I am currently working on 4th task. > I am able to filter lines. > I am trying out to*only* filter lines when =E2=80=9Cguix package=E2=80=9D= is used but > not when =E2=80=9Cguix build=E2=80=9D by adding other port. The next step here would be to not print a dot for each line but to display a spinner instead, i.e. a sequence of characters that look like a spinning animation. For each line the animation could be advanced by one (so it will spin really fast). Danny previously suggested this implementation: https://lists.gnu.org/archive/html/guix-patches/2017-07/msg00068.html You may be able to take a part of that patch and adapt it. The key here is really: keep track of the animation position and use backspace to delete the previously printed character before displaying the next. If you don=E2=80=99t like the spinner animation you could also pick one of these and try implementing them instead: https://stackoverflow.com/questions/2685435/cooler-ascii-spinners Have fun! -- Ricardo