[bug#33283] [PATCH] gnu: Add python-pyelftools.

[bug#33283] [PATCH] gnu: Add python-pyelftools.

[Vagrant Cascadian]

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]


* gnu/packages/python.scm (python-pyelftools):
  New public variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 54ea0caac..c553ab319 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -10578,6 +10578,29 @@ useful as a validator for JSON data.")
 (define-public python2-validictory
   (package-with-python2 python-validictory))
 
+(define-public python-pyelftools
+  (package
+    (name "python-pyelftools")
+    (version "0.25")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pyelftools" version))
+       (sha256
+        (base32
+         "090vdksbz341f7ljvr0zswblw4lspa8qaiikzyjkf318arpxmil9"))))
+    (build-system python-build-system)
+    ;; Test suite requires python-setuptools
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (home-page
+     "https://github.com/eliben/pyelftools")
+    (synopsis
+     "Library for analyzing ELF files and DWARF debugging information")
+    (description
+     "Library for analyzing ELF files and DWARF debugging information")
+    (license license:public-domain)))
+
 (define-public python-pyev
   (package
     (name "python-pyev")
-- 
2.19.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[bug#33283] [PATCH] gnu: Add python-pyelftools.

[Ludovic Courtès]

Hello!

Vagrant Cascadian <vagrant@debian.org> skribis:

> * gnu/packages/python.scm (python-pyelftools):
>   New public variable.

[...]

> +    (home-page
> +     "https://github.com/eliben/pyelftools")
> +    (synopsis
> +     "Library for analyzing ELF files and DWARF debugging information")
> +    (description
> +     "Library for analyzing ELF files and DWARF debugging information")

Could you expound the description a bit?  (See
<https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.)

Otherwise LGTM.

TIA!

Ludo’.

[bug#33283] [PATCH] gnu: Add python-pyelftools.

[Vagrant Cascadian]

[-- Attachment #1.1: Type: text/plain, Size: 768 bytes --]

On 2018-11-05, Ludovic Courtès <ludo@gnu.org> wrote:
> Hello!
>
> Vagrant Cascadian <vagrant@debian.org> skribis:
>
>> * gnu/packages/python.scm (python-pyelftools):
>>   New public variable.
>
> [...]
>
>> +    (home-page
>> +     "https://github.com/eliben/pyelftools")
>> +    (synopsis
>> +     "Library for analyzing ELF files and DWARF debugging information")
>> +    (description
>> +     "Library for analyzing ELF files and DWARF debugging information")
>
> Could you expound the description a bit?  (See
> <https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.)

Updated patch attached with an updated synopsis and description,
attempting to follow the mentioned guidelines.

live well,
  vagrant


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-python-pyelftools.patch --]
[-- Type: text/x-diff, Size: 1675 bytes --]

From ee20fe1b8e0ecb1fb706b7929af5e4bb63843ff5 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@debian.org>
Date: Mon, 5 Nov 2018 19:36:57 +0000
Subject: [PATCH] gnu: Add python-pyelftools.

* gnu/packages/python.scm (python-pyelftools):
  New public variable.
---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 54ea0caac..83a62532b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -10578,6 +10578,31 @@ useful as a validator for JSON data.")
 (define-public python2-validictory
   (package-with-python2 python-validictory))
 
+(define-public python-pyelftools
+  (package
+    (name "python-pyelftools")
+    (version "0.25")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pyelftools" version))
+       (sha256
+        (base32
+         "090vdksbz341f7ljvr0zswblw4lspa8qaiikzyjkf318arpxmil9"))))
+    (build-system python-build-system)
+    ;; Test suite requires python-setuptools
+    (native-inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (home-page
+     "https://github.com/eliben/pyelftools")
+    (synopsis
+     "Analyze binary and library file information")
+    (description "This Python Library provides interfaces for parsing and
+analyzing two binary and library file formats; the Executable and Linking
+Format- ELF, and debugging information in the Debugging With Attributed
+Record Format- DWARF.")
+    (license license:public-domain)))
+
 (define-public python-pyev
   (package
     (name "python-pyev")
-- 
2.11.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#33283: [PATCH] gnu: Add python-pyelftools.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi Vagrant,

Vagrant Cascadian <vagrant@debian.org> skribis:

> From ee20fe1b8e0ecb1fb706b7929af5e4bb63843ff5 Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <vagrant@debian.org>
> Date: Mon, 5 Nov 2018 19:36:57 +0000
> Subject: [PATCH] gnu: Add python-pyelftools.
>
> * gnu/packages/python.scm (python-pyelftools):
>   New public variable.

Applied with extra nitpicking below.  ;-)

Thank you!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 731 bytes --]

--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -10597,10 +10597,10 @@ useful as a validator for JSON data.")
      "https://github.com/eliben/pyelftools")
     (synopsis
      "Analyze binary and library file information")
-    (description "This Python Library provides interfaces for parsing and
+    (description "This Python library provides interfaces for parsing and
 analyzing two binary and library file formats; the Executable and Linking
-Format- ELF, and debugging information in the Debugging With Attributed
-Record Format- DWARF.")
+Format (ELF), and debugging information in the Debugging With Attributed
+Record Format (DWARF).")
     (license license:public-domain)))
 
 (define-public python-pyev