From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43369)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gaOCV-00016R-8E
	for guix-patches@gnu.org; Fri, 21 Dec 2018 12:03:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gaOCU-0004Nb-0g
	for guix-patches@gnu.org; Fri, 21 Dec 2018 12:03:03 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:54489)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gaOCT-0004NV-Rq
	for guix-patches@gnu.org; Fri, 21 Dec 2018 12:03:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gaOCT-0002eh-Kg
	for guix-patches@gnu.org; Fri, 21 Dec 2018 12:03:01 -0500
Subject: [bug#33764] [PATCH] gnu: z3: Update to 4.8.3 and add python{,
	2}-z3 bindings.
Resent-Message-ID: <handler.33764.B33764.15454117468947@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20181216040528.29880-1-bandali@gnu.org> <87bm5lv6tj.fsf@gnu.org>
	<20181217072921.GG3468@macbook41> <87efag6x3w.fsf@aminb.org>
Date: Fri, 21 Dec 2018 18:02:02 +0100
In-Reply-To: <87efag6x3w.fsf@aminb.org> (Amin Bandali's message of "Mon, 17
	Dec 2018 09:34:11 -0500")
Message-ID: <87k1k2olth.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Amin Bandali <bandali@gnu.org>
Cc: 33764@debbugs.gnu.org

Hello!

Amin Bandali <bandali@gnu.org> skribis:

> On 2018-12-17  9:29 AM, Efraim Flashner wrote:
>> On Sun, Dec 16, 2018 at 04:18:16PM +0100, Ludovic Court=C3=A8s wrote:

[...]

>>> > +(define-public python2-z3
>>> > +  (package (inherit python-z3)
>>>=20
>>> This definition cannot be in python.scm; it must be in the same file as
>>> =E2=80=98z3=E2=80=99 or we can get =E2=80=9Cunbound variable=E2=80=9D e=
rrors while loading either of
>>> these two modules.
>
> Oh I see.  If we choose to keep it (add it), I=E2=80=99ll move it to math=
s.scm.
>
>>> Also, as we=E2=80=99re approaching end-of-life upstream for Python 2.x,=
 we now
>>> avoid creating =E2=80=9Cpython2-=E2=80=9D packages, unless we cannot av=
oid it for some
>>> reason.  Do you think we could do without this =E2=80=9Cpython2-z3=E2=
=80=9D package?
>>>=20
>>
>> Currently our z3 package builds python2 bindings
>
> What Efraim said.  Since the current z3 provides python2 bindings, I
> thought I would preserve that option by adding a python2-z3 in case
> anyone wants to continue to use the python2 bindings.
>
> I=E2=80=99m Cc=E2=80=99ing Marius who=E2=80=99s one of the recent committ=
ers to the z3 package
> definition.  Marius, any thoughts on whether we should keep the python2
> bindings around or do away with them?

Marius, WDYT?

Ludo=E2=80=99.