From: Christopher Baines <mail@cbaines.net>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 34650@debbugs.gnu.org
Subject: [bug#34650] [PATCH 3/7] gnu: Add ruby-mustermann.
Date: Mon, 04 Mar 2019 21:20:57 +0000 [thread overview]
Message-ID: <87k1hefi9y.fsf@cbaines.net> (raw)
In-Reply-To: <20190228174435.14499-3-mail@ambrevar.xyz>
[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]
Pierre Neidhardt <mail@ambrevar.xyz> writes:
> * gnu/packages/ruby.scm (ruby-mustermann): New variable.
> ---
> gnu/packages/ruby.scm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index f6b6a19d5..1c10a16c2 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -7708,3 +7708,25 @@ systems that support multiple template engines but don't want to code for each
> of them individually.")
> (home-page "https://github.com/rtomayko/tilt/")
> (license license:expat)))
> +
> +(define-public ruby-mustermann
> + (package
> + (name "ruby-mustermann")
> + (version "1.0.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "mustermann" version))
> + (sha256
> + (base32
> + "0lycgkmnyy0bf29nnd2zql5a6pcf8sp69g9v4xw0gcfcxgpwp7i1"))))
> + (build-system ruby-build-system)
> + (arguments
> + ;; TODO: Fix tests.
> + `(#:tests? #f))
Could you include some details of what is broken about the tests? Even
just a bit of the error message if there is one.
Also, I'd usually use a single quote unless a backtick is necessary.
> + (synopsis "Library implementing patterns that behave like regular expressions")
> + (description "Given a string pattern, Mustermann will turn it into an
> +object that behaves like a regular expression and has comparable performance
> +characteristics.")
> + (home-page "https://github.com/sinatra/mustermann")
> + (license license:expat)))
I'd recommend trying to avoid inserting packages at the end of modules,
or generally in the same place. This can make rebases difficult, and
increase the chances of conflicts when going to apply patches. I
generally try to fit patches in to modules somewhat alphabetically.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2019-03-04 21:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 15:17 [bug#34650] [PATCH] ruby-mailcatcher: Draft Pierre Neidhardt
[not found] ` <handler.34650.B.155110784318701.ack@debbugs.gnu.org>
2019-02-25 15:21 ` [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft) Pierre Neidhardt
2019-02-25 19:10 ` Christopher Baines
2019-02-26 10:59 ` Pierre Neidhardt
2019-02-28 17:44 ` [bug#34650] [PATCH 1/7] gnu: ruby-rack-protection: Update to 2.0.5 Pierre Neidhardt
2019-02-28 17:44 ` [bug#34650] [PATCH 2/7] gnu: Add ruby-tilt Pierre Neidhardt
2019-02-28 17:44 ` [bug#34650] [PATCH 3/7] gnu: Add ruby-mustermann Pierre Neidhardt
2019-03-04 21:20 ` Christopher Baines [this message]
2019-02-28 17:44 ` [bug#34650] [PATCH 4/7] gnu: Add ruby-sinatra Pierre Neidhardt
2019-02-28 17:44 ` [bug#34650] [PATCH 5/7] gnu: Add ruby-thin Pierre Neidhardt
2019-03-04 21:33 ` Christopher Baines
2019-02-28 17:44 ` [bug#34650] [PATCH 6/7] gnu: Add ruby-skinny Pierre Neidhardt
2019-03-04 21:43 ` Christopher Baines
2019-02-28 17:44 ` [bug#34650] [PATCH 7/7] gnu: Add mailcatcher Pierre Neidhardt
2019-03-04 21:50 ` Christopher Baines
2019-03-05 9:09 ` Pierre Neidhardt
2019-03-05 10:27 ` Pierre Neidhardt
2019-03-05 18:51 ` Christopher Baines
2019-02-28 17:47 ` [bug#34650] Acknowledgement ([PATCH] ruby-mailcatcher: Draft) Pierre Neidhardt
2019-03-04 21:06 ` Christopher Baines
2019-03-05 9:18 ` Pierre Neidhardt
2019-03-05 18:51 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1hefi9y.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=34650@debbugs.gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.