From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:39120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYXbC-0000KM-Q9 for guix-patches@gnu.org; Wed, 05 Jun 2019 11:13:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYXb7-00043e-E6 for guix-patches@gnu.org; Wed, 05 Jun 2019 11:13:09 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34341) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYXb4-0003xq-1A for guix-patches@gnu.org; Wed, 05 Jun 2019 11:13:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hYXb3-0003M7-Qr for guix-patches@gnu.org; Wed, 05 Jun 2019 11:13:01 -0400 Subject: bug#36087: [PATCH 0/9] Add further Aspell dictionaries. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87tvd96177.fsf@zete.tk> Date: Wed, 05 Jun 2019 17:11:58 +0200 In-Reply-To: <87tvd96177.fsf@zete.tk> ("Jens \=\?utf-8\?Q\?M\=C3\=B8lgaard\=22's\?\= message of "Sat, 01 Jun 2019 22:37:32 +1200") Message-ID: <87k1e012yp.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jens =?UTF-8?Q?M=C3=B8lgaard?= Cc: 36087-done@debbugs.gnu.org Hello, Jens M=C3=B8lgaard skribis: > I have added some additional Aspell dictionaries. I wasn't sure whether > to separated them out or not, as they're not quite stand-alone packages, > so I'll send them as a patch series - squish them together in one commit > if that makes more sense. I=E2=80=99ve applied them all and adjusted the commit log to follow our conventions. Thanks! There=E2=80=99s a minor issue: the URL computed for the pt-pt dictionary is incorrect, because the URL should read =E2=80=9Cpt_PT=E2=80=9D and not =E2= =80=9Cpt-pt=E2=80=9D. It turns out that the tarball was found on the tarballs.nixos.org content-addressed mirror, so it builds flawlessly. However, it=E2=80=99d be nice to adjust =E2=80=98aspell-dictionary=E2=80=99 so that it can compute t= he right upstream URL for edge cases like this one. Would you like to give it a try? > In case I or someone else wants to add them in the future, some older > dictionaries such as Icelandic and Norwegian Bokm=C3=A5l contain non-utf8 > filenames and will fail to build. Ludovic suggested adding glibc-locales > as input and a pre-unpack phase to do (setlocale LC_ALL > "en_US.iso88591"). Future work! :-) Thanks, Ludo=E2=80=99.