From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#36135: installer wifi password prompt
Date: Mon, 10 Jun 2019 23:38:25 +0200
Message-ID: <87k1dt5df2.fsf@gnu.org>
References: <20190608151502.5d22d7e8@tachikoma.lepiller.eu>
 <87zhmr984t.fsf@gnu.org> <87r2836dnn.fsf@nckx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:34373)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1haS0W-0001jR-5M
 for bug-guix@gnu.org; Mon, 10 Jun 2019 17:39:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1haS0U-0007zA-2e
 for bug-guix@gnu.org; Mon, 10 Jun 2019 17:39:11 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:44026)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1haS0M-0007ul-IT
 for bug-guix@gnu.org; Mon, 10 Jun 2019 17:39:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1haS0M-0006Ei-Ez
 for bug-guix@gnu.org; Mon, 10 Jun 2019 17:39:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.36135.B36135.156020272923946@debbugs.gnu.org>
In-Reply-To: <87r2836dnn.fsf@nckx> (Tobias Geerinckx-Rice's message of "Sat,
 08 Jun 2019 22:11:08 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 36135@debbugs.gnu.org

Hi!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> Ludovic Court=C3=A8s wrote:
>> Tobias Geerinckx-Rice <me@tobias.gr> skribis:
>>
>>> * gnu/installer/newt/wifi.scm (run-wifi-password-page):
>>> Add an #:INPUT-SHOW-CHECKBOX? to the input page.
>>
>> [...]
>>
>>> +                  #:input-show-checkbox? #t))
>>
>> It=E2=80=99s called #:input-hide-checkbox? AFAICS.
>
> Yes.  See the other patches in this ad-hoc =E2=80=98series=E2=80=99.

OK.

>> You can double-check that it builds without warnings with:
>>
>>   guix system vm -v2 gnu/system/install.scm
>
> Sure, I guess, but could you explain the point of doing so?
> Reproducibility by others?  I don't think patches like these should be
> pushed with such light testing, and I don't see how this can be tested
> in a VM.

No argument here!  The patch referred to a keyword argument that does
not exist, which is why I=E2=80=99m indeed suggesting more testing.  Simply
looking at the compiler warnings would have raised a flag.

Ludo=E2=80=99.