From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: bug#24450: [PATCHv2] Re: pypi importer outputs strange character series in optional dependency case. Date: Mon, 17 Jun 2019 03:41:16 +0200 Message-ID: <87k1dlouo3.fsf@mdc-berlin.de> References: <87pnod7ot4.fsf@gmail.com> <87muiq5d7c.fsf@gmail.com> <87blz5dcap.fsf@mdc-berlin.de> <87sgs91uyy.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:52818) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcgep-0002Nv-Na for bug-guix@gnu.org; Sun, 16 Jun 2019 21:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcgeo-0001yM-Qi for bug-guix@gnu.org; Sun, 16 Jun 2019 21:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56438) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcgeo-0001x9-8R for bug-guix@gnu.org; Sun, 16 Jun 2019 21:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hcgeo-0006H7-3j for bug-guix@gnu.org; Sun, 16 Jun 2019 21:42:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87sgs91uyy.fsf@gmail.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Maxim Cournoyer Cc: 24450@debbugs.gnu.org Maxim Cournoyer writes: >> This allows you to match =E2=80=9Ceof-object=E2=80=9D and '() directly. = Whenever I see >> =E2=80=9Cstring-null?=E2=80=9D I think it might be better to =E2=80=9Cma= tch=E2=80=9D on the empty list >> directly. > > string-null? and an empty list are not the same, unless I'm missing somet= hing. Yes, sorry, I meant =E2=80=9Cnull?=E2=80=9D. Using =E2=80=9Cstring-null?= =E2=80=9D is equivalent to matching the empty string, of course. >> But really, that=E2=80=99s up to you. I only feel strongly about avoidi= ng =E2=80=9C(if >> =E2=80=A6 (cond =E2=80=A6))=E2=80=9D. > > Due to the problem mentioned above, I stayed with "cond". Okay! Thanks. --=20 Ricardo