From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#38055: none
Date: Sun, 10 Nov 2019 15:14:42 +0100
Message-ID: <87k1873jjh.fsf@gnu.org>
References: <20191109182510.GA3954@E5400>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:41708)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTnzc-0005Hq-RL
 for bug-guix@gnu.org; Sun, 10 Nov 2019 09:15:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTnza-0000tt-Fq
 for bug-guix@gnu.org; Sun, 10 Nov 2019 09:15:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:41979)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iTnza-0000tp-55
 for bug-guix@gnu.org; Sun, 10 Nov 2019 09:15:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iTnzZ-0000Vz-UJ
 for bug-guix@gnu.org; Sun, 10 Nov 2019 09:15:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.38055.B38055.15733952951950@debbugs.gnu.org>
In-Reply-To: <20191109182510.GA3954@E5400> (Efraim Flashner's message of "Sat,
 9 Nov 2019 20:25:10 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 38055@debbugs.gnu.org, Ivan Vilata i Balaguer <ivan@selidor.net>

Hi,

Efraim Flashner <efraim@flashner.co.il> skribis:

> From 2db156170a24fea36aced781faf96c839a3b7d15 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Sat, 9 Nov 2019 20:19:11 +0200
> Subject: [PATCH] gnu: patchelf: Update to 0.10.
>
> * gnu/packages/elf.scm (patchelf): Update to 0.10.
> [source]: Remove patches.
> [arguments]: Remove patch/rework-for-arm phase. Add phase to modify
> tests for our modified GCC package.
> [native-inputs]: Add gcc:lib.
> * gnu/packages/patches/patchelf-page-size.patch,
> * gnu/packages/patches/patchelf-rework-for-arm.patch: Remove files.
> * gnu/local.mk (dist_patch_DATA): Remove them.

[...]

> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-tests
> +           ;; Our GCC code ensures that RUNPATH is never empty, it inclu=
des
> +           ;; at least glibc/lib and gcc:lib/lib.
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* "tests/no-rpath.sh"
> +               (("^if test.*") "")
> +               (("/xxxxxxxxxxxxxxx") (string-append (assoc-ref inputs "g=
cc:lib")
> +                                                    "/lib")))

Could you complement the above comment with something like: =E2=80=9CThus,
disable the test that checks for an empty RUNPATH.=E2=80=9D, or whatever is
appropriate?  That will clarify the intent because it=E2=80=99s not obvious=
 what
the substitution is doing if you don=E2=80=99t have the file at hand.  :-)

Otherwise LGTM, thanks for addressing this issue!

Ludo=E2=80=99.