From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:33958)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBEh-00081Z-IE
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:00:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBEh-0004Df-0T
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:00:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39714)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jRBEg-0004B3-Gh
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:00:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBEg-0005yH-Ew
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:00:02 -0400
Subject: [bug#40677] [PATCH 01/18] gnu: jami: Move Jami and its dependencies
 to jami.scm.
Resent-Message-ID: <handler.40677.B40677.158754598922900@debbugs.gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
References: <20200417015857.0650ff6a@interia.pl>
 <20200421161032.1847-1-tona_kosmicznego_smiecia@interia.pl>
Date: Wed, 22 Apr 2020 10:59:39 +0200
In-Reply-To: <20200421161032.1847-1-tona_kosmicznego_smiecia@interia.pl> (Jan
 Wielkiewicz's message of "Tue, 21 Apr 2020 18:10:15 +0200")
Message-ID: <87k127q4jo.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
Cc: 40677@debbugs.gnu.org


Hello Jan,

Thanks for the updated serie. I see it has shrunk a bit, which is good!
First two general remarks. As explained by Christopher, you need to
make sure that you pass the version of the patchset to git.

You also need to write commit messages respecting this
https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs
as I already told you.

> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright =C2=A9 2019 Pierre Neidhardt <mail@ambrevar.xyz>

Why is Pierre copyright here?

> +;;; Copyright =C2=A9 2019, 2020 Jan Wielkiewicz <tona_kosmicznego_smieci=
a@interia.pl>

I'm not sure what's the copyright policy when moving stuff to new
files. Someone?

Thanks,

Mathieu