From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:45030)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTL0d-0007oZ-Ma
 for guix-patches@gnu.org; Tue, 28 Apr 2020 03:51:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTKxK-0007sw-F7
 for guix-patches@gnu.org; Tue, 28 Apr 2020 03:50:27 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:55436)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jTKxK-0007so-0F
 for guix-patches@gnu.org; Tue, 28 Apr 2020 03:47:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTKxJ-0006qS-V1
 for guix-patches@gnu.org; Tue, 28 Apr 2020 03:47:01 -0400
Subject: [bug#40902] [PATCH] gnu: Add edid-decode.
Resent-Message-ID: <handler.40902.B40902.158806000826288@debbugs.gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
References: <20200427135550.20640-1-brice@waegenei.re>
Date: Tue, 28 Apr 2020 09:46:38 +0200
In-Reply-To: <20200427135550.20640-1-brice@waegenei.re> (Brice Waegeneire's
 message of "Mon, 27 Apr 2020 15:55:50 +0200")
Message-ID: <87k120uk69.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 40902@debbugs.gnu.org


Hello Brice,

You can add your copyright.

> +(define-public edid-decode
> +  (let ((commit "74b64180d67bb009d8d9ea1b6f18ad41aaa16396") ; 2020-04-22
> +        (revision "1"))
> +   (package
> +     (name "edid-decode")
> +     (version (git-version "0.0.0" revision commit))

The indentation of the block seems wrong.

> +     (source
> +      (origin
> +        (method git-fetch)
> +        (file-name (git-file-name name version))
> +        (uri (git-reference
> +              (url "git://linuxtv.org/edid-decode.git")
> +              (commit commit)))
> +        (sha256
> +         (base32 "0nirp5bza08zj5d8bjgcm0p869hdg3qg3mwa7999pjdrzmn7s2ah"))))
> +     (build-system gnu-build-system)
> +     (arguments
> +      `(#:tests? #f                     ; No test suite
> +        #:make-flags
> +        (list (string-append "DESTDIR=" (assoc-ref %outputs "out"))
> +              "bindir=/bin" "mandir=/share/man")
> +        #:phases
> +        (modify-phases %standard-phases
> +          (delete 'configure))))

When cross-compiling, a native binary is produced. This is because CXX
is set to 'g++' I guess. You need to do something similar to what is
done in the 'maradns' package.

Thanks,

Mathieu