From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cP6rJsPlAl+9cAAA0tVLHw (envelope-from ) for ; Mon, 06 Jul 2020 08:50:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sAKKIsPlAl81cwAA1q6Kng (envelope-from ) for ; Mon, 06 Jul 2020 08:50:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1E5BA940428 for ; Mon, 6 Jul 2020 08:50:11 +0000 (UTC) Received: from localhost ([::1]:33726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsMpF-0007qB-Ql for larch@yhetil.org; Mon, 06 Jul 2020 04:50:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsMp8-0007q3-Kx for bug-guix@gnu.org; Mon, 06 Jul 2020 04:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50276) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsMp8-0001Fn-Bl for bug-guix@gnu.org; Mon, 06 Jul 2020 04:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jsMp8-0005zF-9f for bug-guix@gnu.org; Mon, 06 Jul 2020 04:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41702: `guix environment` performance issues Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 06 Jul 2020 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41702 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Received: via spool by 41702-submit@debbugs.gnu.org id=B41702.159402540123006 (code B ref 41702); Mon, 06 Jul 2020 08:50:02 +0000 Received: (at 41702) by debbugs.gnu.org; 6 Jul 2020 08:50:01 +0000 Received: from localhost ([127.0.0.1]:33588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsMp3-0005yl-9v for submit@debbugs.gnu.org; Mon, 06 Jul 2020 04:50:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsMox-0005yP-RW for 41702@debbugs.gnu.org; Mon, 06 Jul 2020 04:49:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50422) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsMos-0001Do-G5; Mon, 06 Jul 2020 04:49:46 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=50332 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jsMor-0001GE-VN; Mon, 06 Jul 2020 04:49:46 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200604082316.GA3146@zpidnp36> <87mu5gtbwg.fsf@gnu.org> <20200608090453.GC3166@zpidnp36> <87k10hp6ba.fsf@gnu.org> <20200609091522.GB8597@zpidnp36> <87wo3sjjdw.fsf@gnu.org> <87y2o3zf00.fsf@gnu.org> <20200701112453.GB25179@zpidnp36> <87eepuyk99.fsf@gnu.org> <20200702070000.GA4532@zpidnp36> <20200702120333.GB4532@zpidnp36> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 Messidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 06 Jul 2020 10:49:44 +0200 In-Reply-To: <20200702120333.GB4532@zpidnp36> (Lars-Dominik Braun's message of "Thu, 2 Jul 2020 14:03:33 +0200") Message-ID: <87k0zhkoyf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41702@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: y4Z91lMlZ/Qp Hi, Lars-Dominik Braun skribis: > and the attached patch uses the new nodelay option, if we don=E2=80=99t w= ant to wait > for another guile-ssh release. I=E2=80=99d rather wait; perhaps you can ask Artyom whether they=E2=80=99re= planning for a new release soonish? If there=E2=80=99s no plan for a release within two weeks, we can go ahead = with the patch you propose. > From 2892f79f819dd2dd9420f7e74bcb6e293d377452 Mon Sep 17 00:00:00 2001 > From: Lars-Dominik Braun > Date: Thu, 2 Jul 2020 13:59:51 +0200 > Subject: [PATCH] guix: Add nodelay to SSH store connection > > * gnu/packages/ssh.scm (guile-ssh)[patches]: Add patch. > * gnu/packages/patches/guile-ssh-0.12.0-nodelay.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. > * guix/ssh.scm (open-ssh-session): Use new nodelay option. If we take this route, the two patches (guile-ssh changes, then (guix ssh) changes) should be separate. Also #:nodelay will cause a hard failure for people using an older Guile-SSH. I wonder how to guard against that; configure check, or run-time Guile-SSH version check? > +++ b/gnu/packages/patches/guile-ssh-0.12.0-nodelay.patch It would be good to include the URL of the upstream issue Thanks! Ludo=E2=80=99.