From: Mathieu Othacehe <othacehe@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 44800@debbugs.gnu.org
Subject: [bug#44800] [PATCH v2 1/3] Add Avahi support.
Date: Sun, 29 Nov 2020 15:18:24 +0100 [thread overview]
Message-ID: <87k0u4qma7.fsf@gnu.org> (raw)
In-Reply-To: <87k0u6spcj.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 27 Nov 2020 18:04:44 +0100")
Hey Ludo,
Thanks for the review :)
> An argument in favor of making it mandatory is that it would help make
> the feature more widely used, and thus more widely useful.
Yes, and most of the other Guile dependencies are mandatory, so having
Guile-Avahi also mandatory feels safer. Plus I'm sure that it can be
useful for other use cases such as offloading.
> You could use (srfi srfi-9) ‘define-record-type’ since the extra (guix
> records) features are not necessary here.
I use (guix records) feature allowing to call the record constructor
with non positional arguments.
> (I wanted to add an API in Guile-Avahi to “invert inversion of control”
> so that one could escape callback hell but never got around to
> completing it.)
Sure, it would be nice, but given libavahi design, not an easy task :).
> Can’t we obtain the IP address without creating a socket actually? Noob
> here.
I think we can use "getifaddrs" and the its "network-interfaces"
binding, but the resulting code does not seem more readable.
>
>> + ;; Handle service resolution events.
>> + (cond ((eq? event resolver-event/found)
>> + (info (G_ "resolved service `~a' at `~a:~a'~%")
>> + service-name (inet-ntop family address) port)
>
> IWBN to not add UI code in here.
Sure, removed!
Mathieu
next prev parent reply other threads:[~2020-11-29 14:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 15:56 [bug#44800] [PATCH 0/2] publish: Add Avahi support Mathieu Othacehe
2020-11-22 15:56 ` [bug#44802] [PATCH 1/2] " Mathieu Othacehe
2020-11-22 15:56 ` [bug#44801] [PATCH 2/2] publish: Add avahi support Mathieu Othacehe
2020-11-23 22:04 ` [bug#44800] [PATCH 0/2] publish: Add Avahi support zimoun
2020-11-24 13:35 ` Mathieu Othacehe
2020-11-24 13:21 ` [bug#44800] [PATCH v2 0/3] " Mathieu Othacehe
2020-11-24 13:21 ` [bug#44800] [PATCH v2 1/3] " Mathieu Othacehe
2020-11-27 17:04 ` Ludovic Courtès
2020-11-27 17:09 ` zimoun
2020-11-28 11:02 ` Ludovic Courtès
2020-11-28 18:59 ` zimoun
2020-11-29 14:18 ` Mathieu Othacehe [this message]
2020-11-24 13:21 ` [bug#44800] [PATCH v2 2/3] publish: Add avahi support Mathieu Othacehe
2020-11-27 17:12 ` Ludovic Courtès
2020-11-29 14:19 ` Mathieu Othacehe
2020-11-24 13:21 ` [bug#44800] [PATCH v2 3/3] Use substitute servers on the local network Mathieu Othacehe
2020-11-27 17:37 ` Ludovic Courtès
2020-11-29 14:29 ` Mathieu Othacehe
2020-11-30 13:46 ` Ludovic Courtès
2020-12-01 8:43 ` bug#44800: " Mathieu Othacehe
2020-11-27 16:54 ` [bug#44800] [PATCH v2 0/3] publish: Add Avahi support Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0u4qma7.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=44800@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.