From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YzeUMiVBnGDM3AAAgWs5BA (envelope-from ) for ; Wed, 12 May 2021 22:57:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yJuWLSVBnGAsIQAAbx9fmQ (envelope-from ) for ; Wed, 12 May 2021 20:57:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7BA36176FF for ; Wed, 12 May 2021 22:57:09 +0200 (CEST) Received: from localhost ([::1]:60984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgvum-0008A6-GH for larch@yhetil.org; Wed, 12 May 2021 16:57:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgvug-00089o-Mh for guix-patches@gnu.org; Wed, 12 May 2021 16:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgvug-0000Js-Ew for guix-patches@gnu.org; Wed, 12 May 2021 16:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgvug-0002Js-Bv for guix-patches@gnu.org; Wed, 12 May 2021 16:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48232] [PATCH 0/2] Add mercurial-commitsigs and some changes to Mercurial. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 12 May 2021 20:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48232 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 48232@debbugs.gnu.org Received: via spool by 48232-submit@debbugs.gnu.org id=B48232.16208529848869 (code B ref 48232); Wed, 12 May 2021 20:57:02 +0000 Received: (at 48232) by debbugs.gnu.org; 12 May 2021 20:56:24 +0000 Received: from localhost ([127.0.0.1]:40723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgvu3-0002Iz-Ud for submit@debbugs.gnu.org; Wed, 12 May 2021 16:56:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgvtz-0002Ik-M5 for 48232@debbugs.gnu.org; Wed, 12 May 2021 16:56:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44346) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgvtt-00089x-L7; Wed, 12 May 2021 16:56:13 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41122 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgvtt-000170-9F; Wed, 12 May 2021 16:56:13 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <874kf8cno8.fsf@yoctocell.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 =?UTF-8?Q?Flor=C3=A9al?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 12 May 2021 22:56:11 +0200 In-Reply-To: <874kf8cno8.fsf@yoctocell.xyz> (Xinglu Chen's message of "Wed, 12 May 2021 11:21:43 +0200") Message-ID: <87k0o3u0wk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620853029; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=Gpfr4ueOYx0pgSgEf+lmC3VeKfcAzNgQ1lrp3cqL3rE=; b=k40TliaomY3d3OKsICFFyfqtx9jQDGR3/Czhhgh9prbfhNv8xKaTpBEXqApPG9NdS/mqOy /z2MDk8Wx4dmPvhsk10e6VaQ9WwNSNtGjbOaPyIw9+VqsOR/iaVNphatbV9Zp4RTTZdYUo CuX2/kiaB8IWVob7RkttNfzVWJLocbEQCgEnf8e4qaZHs7hgnUPu0+jRksA4+RUXdk8p9Q 8COnzMWggn7XftU2bjyzQohQoKPZWsgdHDxjR0Ym0d2ns3tgpwYco4FuU52kuxLpVj3A9R 0AZfnrDtD51/+a/R7dFV0gWnjdA5CA1uSxVhY4Gx5ZLIDkA2P2zhBoav/C2IOg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620853029; a=rsa-sha256; cv=none; b=ry7qDYNKcksPGI1MmtKRrbr0++w/b3KJcOSJ7IGJQHn8IqwgOSxyaumlNV7jYUgmMFDnBX hpJvzYdAIESmzZ3nvOp7z44XIudoparwKRBbK3W6zC5mR9fDPQ+7+dd7w/YMuYcfv06RwN 1PnQz3odY1VHiDofQowSltQQkp001p0UAebNer1z0YsF4qdgLlYJA1DNq/H4qbJuYVOfU1 FTgt/KO8/47VKv0MTEFbNMdCSZ0QJPfPU4OoeRuoAZQf4fdOM5W7rxS0AOwuQxyXAv1INJ dBFkh/HZGzfnA/wnVQfKxNz0LOPaNXlMGsiLUMZfVenkiNQQXzNoKgIS4Rlo0A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7BA36176FF X-Spam-Score: -2.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: MO17Y/fw0l0+ Hi, Xinglu Chen skribis: [...] > However, two of the tests are failing, they are related to multiple > people trying to push to the same repo at the same time. I don=E2=80=99t= know > why they would fail, and I don=E2=80=99t know if my patch will break thin= gs in > the =E2=80=9Creal world=E2=80=9D. > > This is needed to make Mercurial read the HGEXTENSIONPATH to detect > third-party extensions. It is called HGEXTENSIONPATH and not > HG_EXTENSION_PATH to keep it consistent with other environment variables = for > Mercurial, e.g. HGENCODINGAMBIGUOUS, HGEDITOR ... Hopefully I or someone= else > will get this into Mercurial proper. > > diff --git a/mercurial/extensions.py b/mercurial/extensions.py > --- a/mercurial/extensions.py > +++ b/mercurial/extensions.py > @@ -13,6 +13,7 @@ > import imp > import inspect > import os > +import sys >=20=20 > from .i18n import ( > _, > @@ -108,6 +109,8 @@ >=20=20 > def _importh(name): > """import and return the module""" > + # Read HGEXTENSIONPATH environment variable when import extensions. > + sys.path.append(os.getenv("HGEXTENSIONPATH")) Perhaps you need to handle the case where HGEXTENSIONPATH is undefined? (This could explain the test failures that you see, no?) Also, I=E2=80=99m no Pythonista, but if =E2=80=98sys.path=E2=80=99 is a lis= t, then you have to split the value of HGEXTENSIONPATH on colons. Thanks, Ludo=E2=80=99.