From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kyle Meyer <kyle@kyleam.com>
Cc: zimoun <zimon.toutoune@gmail.com>,
49457@debbugs.gnu.org, Andrew Tropin <andrew@trop.in>
Subject: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch.
Date: Thu, 08 Jul 2021 13:38:14 +0200 [thread overview]
Message-ID: <87k0m1nihl.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87mtqx82or.fsf@kyleam.com> (Kyle Meyer's message of "Thu, 08 Jul 2021 07:28:36 -0400")
Hello,
Kyle Meyer <kyle@kyleam.com> writes:
> Nicolas Goaziou writes:
>
>> However, I think it is a bug if Emacs Magit does not work with git in
>> profile. We should modify the source so both magit-git-executable and
>> magit-gitk-executable point to those from inputs.
>>
>> I suggest to open a new bug report about it, WDYT?
>
> Rewriting magit-git-executable to an absolute file name will break Magit
> for those that use it over TRAMP.
Point taken. However, such users can fix it by modifying the
`magit-git-executable' defcustom again, can't they?
So, the situation would arguably not be worse that what it is currently,
since it simply doesn't work for users relying on a local installation
of git, and those are probably more common.
Also, a third option: since we're not making use of git input at
runtime, why should it be an input at all? If it is needed at build
time, a native-input should suffice.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-07-08 11:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 13:59 [bug#49457] [PATCH] gnu: Add emacs-consult-notmuch Andrew Tropin
2021-07-07 14:12 ` [bug#49457] [PATCH v2] " Andrew Tropin
2021-07-07 14:18 ` Nicolas Goaziou
2021-07-07 14:33 ` Andrew Tropin
2021-07-08 7:41 ` Nicolas Goaziou
2021-07-08 9:13 ` zimoun
2021-07-08 9:41 ` Nicolas Goaziou
2021-07-08 11:28 ` Kyle Meyer
2021-07-08 11:38 ` Nicolas Goaziou [this message]
2021-07-09 0:13 ` Kyle Meyer
2021-07-08 10:14 ` Andrew Tropin
2021-07-08 7:40 ` bug#49457: " Nicolas Goaziou
2021-07-08 10:22 ` [bug#49457] " Andrew Tropin
2021-07-08 10:32 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0m1nihl.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=49457@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=kyle@kyleam.com \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.