From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qBH0H/ueE2FdBAEAgWs5BA (envelope-from ) for ; Wed, 11 Aug 2021 11:57:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4I1dG/ueE2EXEAAAB5/wlQ (envelope-from ) for ; Wed, 11 Aug 2021 09:57:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1A1BE1B986 for ; Wed, 11 Aug 2021 11:57:15 +0200 (CEST) Received: from localhost ([::1]:44092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDkz4-0006nv-5c for larch@yhetil.org; Wed, 11 Aug 2021 05:57:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDkyt-0006nY-Kk for guix-patches@gnu.org; Wed, 11 Aug 2021 05:57:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50136) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDkys-0001k9-IK for guix-patches@gnu.org; Wed, 11 Aug 2021 05:57:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mDkys-0006jA-Hh for guix-patches@gnu.org; Wed, 11 Aug 2021 05:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49823] [PATCH] gnu: Add jsonnet. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 11 Aug 2021 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49823 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vivien Kraus Cc: 49823@debbugs.gnu.org, Leo Prikler , Maxime Devos Received: via spool by 49823-submit@debbugs.gnu.org id=B49823.162867582125852 (code B ref 49823); Wed, 11 Aug 2021 09:57:02 +0000 Received: (at 49823) by debbugs.gnu.org; 11 Aug 2021 09:57:01 +0000 Received: from localhost ([127.0.0.1]:33449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDkyr-0006it-2X for submit@debbugs.gnu.org; Wed, 11 Aug 2021 05:57:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDkym-0006if-ML for 49823@debbugs.gnu.org; Wed, 11 Aug 2021 05:57:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53328) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDkye-0001au-WE; Wed, 11 Aug 2021 05:56:49 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48742 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDkye-0002rO-NW; Wed, 11 Aug 2021 05:56:48 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <71fbbaa57a2c1dba8f0d956ea162c2e15d332e0c.camel@planete-kraus.eu> <878s19sbgf.fsf@gnu.org> <874kbx2x3e.fsf@planete-kraus.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 Thermidor an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 11 Aug 2021 11:56:46 +0200 In-Reply-To: <874kbx2x3e.fsf@planete-kraus.eu> (Vivien Kraus's message of "Tue, 10 Aug 2021 16:28:05 +0200") Message-ID: <87k0kspan5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628675835; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=61QBhlSZHWYXvGQOhu/4VecXeiLBnsOl6/g5hmXDSTc=; b=iob/QZhlcSI5JkqdE/KkpbfsdQKjlCbl+yCvTj7sXsvLGHTEQ3mZiUAgUu+leCxsFVRszr 8uX9tLeeQ5ceQ2h7em0PUVZgp9FJAKgaRT2vN429W1Gd/2B2oCv0Q4d3q2wKNkECvrSYmW 9RB9vj5yosb/1VwbRPynzQtYDbvKisYJEDu77YmERXFm/7KKdbWqo8VvwsPcwtuuf0CF1u /nC09OX0GjF6KMjhkvlvuUV0mIRMGSS5vH7rcGM9m4W0wv43uBVyPzxBOgGDSnpvZTWWoU JDl0WpCQJU1+kOeDRbg/MczuG/vDl/XeGL9TCOV6GZYTRklfNUsouYxAk5aspA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628675835; a=rsa-sha256; cv=none; b=aCDfWUdUQmV2Lhp7Fr8Z4oqPajtRlIAOVE7Qwin2p3dYi+HDojCr3B4ulEzOch2RXitkSQ PXbiKOP44Q1OmHNKYemZZ5MI+mrFA77qYuMSwVE8HMnEqVACe3B9YOZpl7kJo6QF3HdAqK +msjwWqufqddkDM9hJBW39iF/prUQdvrd1OJ0sgjyfxELlobzLeqs3WV0U1PJ/6ZsmZ89j KKxEeNf71d1qnMA8CkzU1mH9KIe3woZHutabiMCQ3Is38kEYhbecc9DiRnO7cGsZAwMjYw liQsWpPu+pd/IO9rJ0vr32WOCT4dDr0B3089jXYJKP1sdgZh+yp/N4TW6JjWpg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1A1BE1B986 X-Spam-Score: -2.91 X-Migadu-Scanner: scn1.migadu.com X-TUID: 9Vrg3ENnR1J0 Hi, Vivien Kraus skribis: > Ludovic Court=C3=A8s writes: >>> For the sake of having "no dependencies", it bundles a custom >>> implementation of MD5. According to a comment in the associated >>> license, it is taken from the implementation of bzflag, but it does not >>> seem to use the same as of today. >>> >>> I decided to use nettle, and add a few lines of C++ to shape it into >>> the required interface. >> >> I think using Nettle is a wise decision; however, it=E2=80=99s a decisio= n for >> upstream to make IMO. I=E2=80=99m not comfortable with shipping custom >> md5.{cpp,h} and CMakeLists.txt; to me, we=E2=80=99d be taking a bit too = much of >> upstream=E2=80=99s burden and delivering something that=E2=80=99s quite = different. > > OK. Should I keep the bundled MD5 implementation then? Yeah, I think so. Clearly it=E2=80=99s a gray area, there are pros and con= s, but I=E2=80=99d lean towards minimal changes to upstream source. Thanks, Ludo=E2=80=99.