From: Josselin Poiret <dev@jpoiret.xyz>
To: Demis Balbach <db@minikn.xyz>, guix-devel@gnu.org
Cc: dev@jpoiret.xyz
Subject: Re: bluetooth-service: addition config vaules
Date: Sat, 11 Dec 2021 14:57:17 +0100 [thread overview]
Message-ID: <87k0gbfdmq.fsf@jpoiret.xyz> (raw)
In-Reply-To: <87mtl8fxj5.fsf@minikn.xyz>
Hello,
Demis Balbach <db@minikn.xyz> writes:
> If someone can explain to me how to test and submit it myself, I'll do
> it. But I head that it's not as easy as submitting a patch for a
> package. I believe a seasoned contributer could submit something way
> faster.
>
> In any case,
>
> Best regards / Mit freundlichen Grüßen,
> Demis Balbach
I think this is pretty approachable, especially given the fact that you
don't need to write the whole service from scratch.
All of the following takes place in gnu/services/desktop.scm: the
options given to the service via the bluetooth-configuration record end
up being inserted into the gexp that the bluetooth-directory procedure
returns, which is itself used to build the actual /etc/bluetooth/
directory for the system (see "G-Expressions" in the manual if you want
more info about gexps, although you won't need to manipulate them for
this). The contents of the main.conf file are generated with the
bluetooth-configuration-file procedure, which contains only basic string
manipulation.
So, in order to add new options to the bluetooth service,
you would need to only modify the bluetooth-configuration record to add
them, with proper defaults, as well as add the relevant lines in
bluetooth-configuration-file. As to testing, you could simply run `guix
system build some-test-system-conf.scm` and check that the resulting
/gnu/store/xxxx-system/etc/bluetooth/ folder contains the proper
configuration file. Ideally, you would also test if the features
themselves end up working properly, but I am hopeful that bluetoothd
will handle them just as well.
Good luck!
Best,
Josselin Poiret
next prev parent reply other threads:[~2021-12-11 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 12:35 bluetooth-service: addition config vaules Demis Balbach
2021-12-11 13:57 ` Josselin Poiret [this message]
2021-12-11 17:02 ` Demis Balbach
2021-12-13 19:38 ` Demis Balbach
2021-12-17 13:33 ` Demis Balbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0gbfdmq.fsf@jpoiret.xyz \
--to=dev@jpoiret.xyz \
--cc=db@minikn.xyz \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.