From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oAZiJK1LRWIY6gAAgWs5BA (envelope-from ) for ; Thu, 31 Mar 2022 08:35:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qEH+HK1LRWK2DgEAG6o9tA (envelope-from ) for ; Thu, 31 Mar 2022 08:35:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F1CD6F003 for ; Thu, 31 Mar 2022 08:35:24 +0200 (CEST) Received: from localhost ([::1]:42376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZoOy-0003s1-2b for larch@yhetil.org; Thu, 31 Mar 2022 02:35:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZoNe-0003nH-A8 for guix-patches@gnu.org; Thu, 31 Mar 2022 02:34:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZoNd-0007Qg-Ty for guix-patches@gnu.org; Thu, 31 Mar 2022 02:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZoNd-0002wX-Ps for guix-patches@gnu.org; Thu, 31 Mar 2022 02:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54635] [PATCH 1/5] gnu: gsl: Force bootstrap when cross-compiling to riscv64-linux. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 31 Mar 2022 06:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54635 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner , Maxime Devos Cc: 54635@debbugs.gnu.org Received: via spool by 54635-submit@debbugs.gnu.org id=B54635.164870842711293 (code B ref 54635); Thu, 31 Mar 2022 06:34:01 +0000 Received: (at 54635) by debbugs.gnu.org; 31 Mar 2022 06:33:47 +0000 Received: from localhost ([127.0.0.1]:37509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZoNP-0002w5-24 for submit@debbugs.gnu.org; Thu, 31 Mar 2022 02:33:47 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:51812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZoNL-0002vu-HO for 54635@debbugs.gnu.org; Thu, 31 Mar 2022 02:33:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lk3ZEIiD6QT8sCw0rtogSNiVKA0Qh/6bAKIuGhbHa88=; b=QAw2MnlOu+5qRQNnYWPSEsIHyM xqbfEFq3Db7l4k2g9P/JEIPvjlh5BAss2q4H9kW2iHGFupM6F6cpIqaBrta0r58bA429esTMxoSGu /YR/RzhHSxZcMfibPmf9ig9REeGpaVPZdRfNk/1KvJNFvAJLRM8ep/CwGfn9RY/25MtZuVeWKCUAh NLuSje6FOYEOnpxEbWLtb1NmVCK5ad/AsyE2yFEwUSOG3v2D5lNjY7/OiHBcwOc7WRv0uqjOgUTBU 1DPF9YWGf6h+T3KZUgJv4DPXb/N+taktSnqR5tpEzPlwAIXDgFIhefphxgoLiB298qBQ6db02zLcA ATIt4sVQ==; Received: from [192.168.2.1] (port=57830 helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1nZoNI-000V23-0e; Thu, 31 Mar 2022 12:03:40 +0530 From: Arun Isaac In-Reply-To: References: <20220330091913.23206-1-arunisaac@systemreboot.net> <20220330092313.23584-1-arunisaac@systemreboot.net> Date: Thu, 31 Mar 2022 12:03:39 +0530 Message-ID: <87k0cazl4s.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648708525; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lk3ZEIiD6QT8sCw0rtogSNiVKA0Qh/6bAKIuGhbHa88=; b=nPNj/TQq5tgrSlRgL8+4TWFJLJi8zFY6NZ5VKiwNMgwdFGRTthT2ztwwJbF54kDRK22ePc SLYsTlYHZ9HCPVl2FVXVw1GagWmhQBIjeyp03InOPqns/lUADaJZPbrr6sKxxAEd/9uRst 6I9x/SDGtL2Hwk9RdkhZepa3qiyOFZk/1pBdndA4jq7mngnzVdfqFLHv+qAolil7EAcrpv VfnkGzjZL5LfJ9h7SyLXA5+vMhFj5STNjU4DxpWRKZ9sS/HDV/IM0L3PULI47IK9i3dvSG CgbCc3jo0744Bv2cxxJKh3ruo64N3jobxUAQVpBTm4ozK/30IJMvc/+khMTM8A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648708525; a=rsa-sha256; cv=none; b=KFQiHal8KnhRiKoQ4oHXt2wENdXGQSfycgNr7cIC3Gq/h6pdqFDnfSyeTIfbEuhJc3cEeN t7LxqVm/y5CZ/6WGEYnh/mnnVVwct5UmDU0yN8LKtMUwDV8tSUupOTTlM5b0+cskxPK4AU P0ogkSMhVv3CkhM7fD6Xjj9d2lBsdQOoINC7PY3FOwC0LSLYSatfsEAx+jzdnwB3l/rz/N 4DjGobAU4wCqZ+HL1aWP9anZ65KRujrgXdTg3VNLG8dKih3ZMiABPEpfRdLWLRp0++gMHR LsQyhu+Dmdqk/8DqxugnT//sx9tiMzpT2jq8w+8F1tzCiVXHAaneKEYtXqD07g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=QAw2MnlO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=QAw2MnlO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F1CD6F003 X-Spam-Score: 5.93 X-Migadu-Scanner: scn1.migadu.com X-TUID: /O1wwh11J58+ >> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ,@(= cond >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 ((target-riscv64?) >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 '((add-after 'unpack 'force-bootstrap >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lambda _ >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; gsl ships with an ol= d configure script that does not >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; support riscv64. Reg= enerate it. >> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (delete-file "configure= "))))) >> > + >>=20 >> WDYT of making this unconditional? Two benefits: >>=20 >> * if Guix is ported to another new architecture, >> then no changes are necessary to the package definition. >>=20 >> * 'configure' and 'Makefile.in' are not source code, >> and more difficult to audit for things like malware than >> 'configure.ac' and 'Makefile.am'. > > This can be with a TODO for core-updates. gsl itself has about 2000 > dependant packages. I agree. That was my reasoning as well. If we agree that making it unconditional is the way forward, I can send another patch for core-updates after this patchset is pushed to master. > That said, I'm not convinced about unilaterally removing configure > unless we make it a policy to remove it. Also, I haven't had trouble > with building gsl on riscv64-linux without this patch. Without the force-boostrap phase, the configure phase fails during cross-compilation. --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build --target=3Driscv64-linux-gnu gsl [...] starting phase `configure' source directory: "/tmp/guix-build-gsl-2.7.drv-0/gsl-2.7" (relative from bu= ild: ".") build directory: "/tmp/guix-build-gsl-2.7.drv-0/gsl-2.7" configure flags: ("CC_FOR_BUILD=3Dgcc" "CONFIG_SHELL=3D/gnu/store/4y5m9lb8k= 3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/bash" "SHELL=3D/gnu/store/4y= 5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/bash" "--prefix=3D/gn= u/store/x7ag3i38ykn2l3f6sfn06bn9356kdk0x-gsl-2.7" "--enable-fast-install" "= --build=3Dx86_64-unknown-linux-gnu" "--host=3Driscv64-linux-gnu" "--disable= -static") checking for a BSD-compatible install... /gnu/store/d251rfgc9nm2clzffzhgiip= dvfvzkvwi-coreutils-8.32/bin/install -c checking whether build environment is sane... yes checking for riscv64-linux-gnu-strip... riscv64-linux-gnu-strip checking for a race-free mkdir -p... /gnu/store/d251rfgc9nm2clzffzhgiipdvfv= zkvwi-coreutils-8.32/bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... no checking whether make supports nested variables... yes checking whether to enable maintainer-specific portions of Makefiles... no checking for a sed that does not truncate output... /gnu/store/wxgv6i8g0p24= q5gcyzd0yr07s8kn9680-sed-4.8/bin/sed checking whether make sets $(MAKE)... (cached) no checking build system type... x86_64-unknown-linux-gnu checking host system type... Invalid configuration `riscv64-linux-gnu': mac= hine `riscv64' not recognized configure: error: /gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-= 5.1.8/bin/bash ./config.sub riscv64-linux-gnu failed error: in phase 'configure': uncaught exception: %exception #<&invoke-error program: "/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6h= acd16-bash-minimal-5.1.8/bin/bash" arguments: ("./configure" "CC_FOR_BUILD= =3Dgcc" "CONFIG_SHELL=3D/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-mi= nimal-5.1.8/bin/bash" "SHELL=3D/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-= bash-minimal-5.1.8/bin/bash" "--prefix=3D/gnu/store/x7ag3i38ykn2l3f6sfn06bn= 9356kdk0x-gsl-2.7" "--enable-fast-install" "--build=3Dx86_64-unknown-linux-= gnu" "--host=3Driscv64-linux-gnu" "--disable-static") exit-status: 1 term-s= ignal: #f stop-signal: #f>=20 phase `configure' failed after 0.3 seconds command "/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin= /bash" "./configure" "CC_FOR_BUILD=3Dgcc" "CONFIG_SHELL=3D/gnu/store/4y5m9l= b8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/bash" "SHELL=3D/gnu/store= /4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/bash" "--prefix=3D= /gnu/store/x7ag3i38ykn2l3f6sfn06bn9356kdk0x-gsl-2.7" "--enable-fast-install= " "--build=3Dx86_64-unknown-linux-gnu" "--host=3Driscv64-linux-gnu" "--disa= ble-static" failed with status 1 builder for `/gnu/store/fwjvvklmswc9midrcdg6qir2knvmraif-gsl-2.7.drv' faile= d with exit code 1 build of /gnu/store/fwjvvklmswc9midrcdg6qir2knvmraif-gsl-2.7.drv failed View build log at '/var/log/guix/drvs/fw/jvvklmswc9midrcdg6qir2knvmraif-gsl= -2.7.drv.gz'. guix build: error: build of `/gnu/store/fwjvvklmswc9midrcdg6qir2knvmraif-gs= l-2.7.drv' failed --8<---------------cut here---------------end--------------->8---