From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OL//MKrgzmLdigAAbAwnHQ (envelope-from ) for ; Wed, 13 Jul 2022 17:11:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WD7jMKrgzmKNsQAA9RJhRA (envelope-from ) for ; Wed, 13 Jul 2022 17:11:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 836278238 for ; Wed, 13 Jul 2022 17:11:38 +0200 (CEST) Received: from localhost ([::1]:33586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBe1Z-0002aX-O9 for larch@yhetil.org; Wed, 13 Jul 2022 11:11:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBe10-0001yg-58 for bug-guix@gnu.org; Wed, 13 Jul 2022 11:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53639) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oBe0z-0001zw-On for bug-guix@gnu.org; Wed, 13 Jul 2022 11:11:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oBe0z-0002e6-Hd for bug-guix@gnu.org; Wed, 13 Jul 2022 11:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#34170: bitcoin-core bundles leveldb Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 13 Jul 2022 15:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34170 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Carl Dong Cc: 34170@debbugs.gnu.org, Danny Milosavljevic , Maxime Devos , zimoun Received: via spool by 34170-submit@debbugs.gnu.org id=B34170.165772505110151 (code B ref 34170); Wed, 13 Jul 2022 15:11:01 +0000 Received: (at 34170) by debbugs.gnu.org; 13 Jul 2022 15:10:51 +0000 Received: from localhost ([127.0.0.1]:47536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBe0p-0002df-FO for submit@debbugs.gnu.org; Wed, 13 Jul 2022 11:10:51 -0400 Received: from mail-qv1-f51.google.com ([209.85.219.51]:39534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBe0n-0002dR-NB for 34170@debbugs.gnu.org; Wed, 13 Jul 2022 11:10:50 -0400 Received: by mail-qv1-f51.google.com with SMTP id nd6so5022608qvb.6 for <34170@debbugs.gnu.org>; Wed, 13 Jul 2022 08:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+k3hU54AjQRD6zUtPGIPe/7xtRgbQJOf8+1Bp/cpy6w=; b=Fw8AIAXHj5aGQBbxKFlG97YwTS5rRN3yMYnsoryXeDoPEs5ChSDZFoPidP1u3a3Wio ZrzdS+mv/1WLkAytnwX0BFCp2vdzpGi906Vbx0BhczcRJr66FSSSU1ziGiyVJGCPjzqL /AekgRG2IdMmMHTc5pLLNa4FYz9mVvEOj/DMiJso7WShjN/nAdU+t7MinU+MHpplDe1s 0YKfeAa5QQGf+zS9TqJFCXVviyZ1iOcJDIPVTcy/TbsYTXZkHXPn5mdS2aAKCqIPxKgq pUf1sl9ncy57X8zzTw8ql5E9voYM5kl/A5t7syHdoLF9URD6JuVQKl5LqjomHE52LhL/ rV9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+k3hU54AjQRD6zUtPGIPe/7xtRgbQJOf8+1Bp/cpy6w=; b=8JqMX0ap3AQARs0Q69D1hGVPSrH+N/M3MvFitVoUGqKxh5Xxjkw4dnWHKMtSdv83fr C4xWLYTQD9F3RYynWuw01kUqzUzMQjpOve8I/h1sWaFg29SjTpwuvaMt/+cMzQHvkL3D lap9HjhUHx6jUyeIeLn69Wlsua6R95bvz7u7JRRwvPcio8VwJoL3J79D9oEz2JKDybhd z4wmP09vjD5lERkF1Yzge7A35PX1rKCv2xB00pOBVTp9GiNHiQ6yuZD696xA9Evt/ueQ Br/omGrPuQBv4GozOfAsJ8xDbkOK+2boxF5CC0QtOqa25zJ1gjh//jQslkoupIWK7mF0 i36Q== X-Gm-Message-State: AJIora93lFfIK+vtTShRj7Wi7kJenwlwoM0McL583sis4FSxKczdkcOX K/udTmn5tUbi4aYsS8KUK98= X-Google-Smtp-Source: AGRyM1vz3MRTTw0+sWIM1AiavmCy3PG6AgziftZROr7Nh7YlGUK5XkPuBv7Yj2MmNDRoUYdh0+rAZA== X-Received: by 2002:a05:6214:2b0d:b0:473:80c9:c0b6 with SMTP id jx13-20020a0562142b0d00b0047380c9c0b6mr3478318qvb.82.1657725043580; Wed, 13 Jul 2022 08:10:43 -0700 (PDT) Received: from hurd (dsl-10-133-49.b2b2c.ca. [72.10.133.49]) by smtp.gmail.com with ESMTPSA id u13-20020a05620a0c4d00b006a6ebde4799sm11998813qki.90.2022.07.13.08.10.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:10:43 -0700 (PDT) From: Maxim Cournoyer References: <20190122133124.7ca032d7@scratchpost.org> <865ys6m168.fsf@gmail.com> <86lezu8qj4.fsf@gmail.com> <26B84833-6F9F-4C5D-8448-715C67C16768@carldong.me> <563546ec57ff4726bf4138c16be6304c869119ce.camel@telenet.be> <70A07344-0DA9-4A8E-B3B0-FAE1721FE2D2@carldong.me> Date: Wed, 13 Jul 2022 11:10:42 -0400 In-Reply-To: <70A07344-0DA9-4A8E-B3B0-FAE1721FE2D2@carldong.me> (Carl Dong's message of "Thu, 6 Jan 2022 19:17:13 -0500") Message-ID: <87k08hyrnx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657725098; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+k3hU54AjQRD6zUtPGIPe/7xtRgbQJOf8+1Bp/cpy6w=; b=CEqLd3Jl+NL1XuzietdTM70eunAjmtHNNw9XiQaT1jqJLRlKCpfodbtdAoOcnFGCYK8LnJ X80JLiKuqC5U7XtMw7noPHRnhz7HuM0ncXitoy/HATqfOJebeJR44W/lfzASlaDFWBVN4h K6haIqd3Wjb+EK82lIMHRltJqlJeyODT2FU18EPz0wCBkIjgQHgrC0u7NOUBDFYc8v8TRW xFHUiXnCe+Xeu3diYCwPOFzhbsD7jvcZiZFyHg+mP2neUsgVuz4L9ghcO8Bov2OIaGl/4y LusGW29afr6d+lOgqpcuk9/BseSD5AmOnzbhYT43/e6C+FUgKLj2CiSZX97N8A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657725098; a=rsa-sha256; cv=none; b=QA3Zqr/Z6sNDNa7ZNx6z3AqKPNeFmHtKKUV1mm5XtVWaJsQfzMMNhqD6g7nkkwqMmOEaFk 2AfwR6WsZEmplgMHmVMqeqtGMZuvzNV3Ufy6UjHM82vmvorGzSlKrk0ObqMAz0haNGC3k4 X9xt1435Q0+nnQozuGnN/sjkVsHRZyD7dIFq0r58lXB531vKhkNNVKuq/7ivl73is8zQNJ sIgeNJtqT5damU7T/Z7at79XsFo4A8oj6ZazXdT0f4+NyR8tmFqzzdo/GM59NobOzn91Cl qLVqiHaWNyAs8d1G2jdZCd8c2NveatRnNjHpnGBq+oAUAji6gn/Ul2DS0UEbLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Fw8AIAXH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.56 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Fw8AIAXH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 836278238 X-Spam-Score: 7.56 X-Migadu-Scanner: scn1.migadu.com X-TUID: k+pvFwhIDG6+ Hi Carl, Carl Dong writes: >> If desired, it would also be possible to do something in-between >> unbundling and using bitcoin's leveldb: define a 'leveldb/bitcoin' >> variant of the 'leveldb' package (using package/inherit or (package >> (inherit ...) ...)), add it as input to the 'bitcoin' package and tell >> and/or patch bitcoin's buid scripts to use that leveldb. > Yes I think that would be a splendid idea! With regards to patching > bitcoin=E2=80=99s builds scripts, Bitcoin Knots follows Bitcoin Core clos= ely, > but has a bunch of patches which allow for using system libs, so that > might be good to reference: > https://github.com/bitcoin/bitcoin/compare/master...bitcoinknots:21.x-sys= libs > > >> As source code, use an appropriate commit from >> (and add a comment >> to the definition of bitcoin-core to keep leveldb/bitcoin in-sync). > > FYI, according to https://github.com/bitcoin/bitcoin/pull/17398 > , we are currently > using the upstream LevelDB commit > 0c40829872a9f00f38e11dc370ff8adb3e19f25b Would you like to give the idea discussed above a try and send a patch? That'd bring closure to this old issue :-). Thanks, Maxim