From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uCaFMvkQDWPaAgEAbAwnHQ (envelope-from ) for ; Mon, 29 Aug 2022 21:18:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YNuSMfkQDWNkWQAAG6o9tA (envelope-from ) for ; Mon, 29 Aug 2022 21:18:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 616428931 for ; Mon, 29 Aug 2022 21:18:17 +0200 (CEST) Received: from localhost ([::1]:43818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oSkH2-00018A-KU for larch@yhetil.org; Mon, 29 Aug 2022 15:18:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSkGo-00016k-9r for bug-guix@gnu.org; Mon, 29 Aug 2022 15:18:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44117) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oSkGo-0005jO-17 for bug-guix@gnu.org; Mon, 29 Aug 2022 15:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oSkGn-0003cO-SU for bug-guix@gnu.org; Mon, 29 Aug 2022 15:18:01 -0400 Subject: bug#57272: libvirt 8.6 fails to start network Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Mon, 29 Aug 2022 19:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 57272 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Lars-Dominik Braun , 57272-done@debbugs.gnu.org Mail-Followup-To: 57272@debbugs.gnu.org, marius@gnu.org, lars@6xq.net Received: via spool by 57272-done@debbugs.gnu.org id=D57272.166180066513880 (code D ref 57272); Mon, 29 Aug 2022 19:18:01 +0000 Received: (at 57272-done) by debbugs.gnu.org; 29 Aug 2022 19:17:45 +0000 Received: from localhost ([127.0.0.1]:33865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSkGW-0003bm-RX for submit@debbugs.gnu.org; Mon, 29 Aug 2022 15:17:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSkGU-0003bY-Ut for 57272-done@debbugs.gnu.org; Mon, 29 Aug 2022 15:17:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSkGN-0005gq-NO; Mon, 29 Aug 2022 15:17:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=p4jMsACkxGqY1qkcwEqO4+BSIPDkPGsB9b3/aa0HB1Y=; b=dPkl22TYmvRAakAGGA1R WrbLzJ2XXT18msJrXcOPvbtRlgKD5UjPE93EyuBoJf2VtGDs9IKX/7N14JJfMe1yEavEPqsBM/qW8 wmBc0vh0b3j3HTGrvT9/ZNN7JOVpsYc4Rdw9a8nFWbSWMn4b1ydNmHqrl6Z7JTs8b21wn9cAB/Wlw N9ovUXya6ZkOgsET5ou3T2T5bJHvls2P7RVsIv0gWTXkufvV3hiDABj4kBZeATMIhdxy1adXrMssp vMMMXgNaUNYHJFw5x6p2GoOlxVfTYkWeskZX2HzBBRv6vTvmadhiJ3grQbHZiU9CLNRFlqmSG5qo3 Ran+vYr/SNH33Q==; Received: from [84.214.173.6] (port=58736 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSkGN-0000rU-7a; Mon, 29 Aug 2022 15:17:35 -0400 From: Marius Bakke In-Reply-To: References: Date: Mon, 29 Aug 2022 21:17:31 +0200 Message-ID: <87k06qdflg.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661800697; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=p4jMsACkxGqY1qkcwEqO4+BSIPDkPGsB9b3/aa0HB1Y=; b=u55kCAxmpigjxsnCUIZlD9Dw/2JqP7UkAr7JlLEWgHau2kisrKk/ANFnY0+DXORtwa/8Sa kciccarvUg6GTCDYwyMEzIHuuoX9lymvjdEnfftKeO1CHteg4GhnaxMf7YCT+E/Z3tuj6m kbo+6l5AJzF7Fxj5QBDaJi+QlKLZe4AGSvnQnQtm13vpv+9RCoMd+Sj4a+AiF8QlfSKNTB ee2dugJo0QoDg+FoMylMYpUvQZJVLwU2UmNTuOFTEGB4spMh0JxnMPL94UmLYApmegmHol JBR7X7loNSChnWACfdc1rnspRTgolDE/Gojrh3Gv6HmEbpUH8BqEwtNAQ4ZEFQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661800697; a=rsa-sha256; cv=none; b=e9HgUrwmEdbwxzFaV5vgws0f6xfoIWvbTb8Czn9BG88a53Soj+32U9YwT2TxV7VkifWxtN 4Sp/OtDGPRTleU+5/Xx+Ef0UmkintPc4l+lOJpQXIFKefWIUbmoTSVanWjitGgs57el4Em 6KAbKHQuTb1jAdZdkbSuGffFnfb8hDRy0f3GIxBL2LWTFoXMsmtrwm1nIG1y85oCCrqdle V1tAvKLajL0WQ/tcbICA6+R6URd5fbmIZ9+sEKQNN1lYb/Y8IjGnzNRMdNbDLjr6ajNWfa PN8NdSE3VBN2hUoDPZGpj4gF1ipAXBOmtdiAgnVrrT6qY/eB8ZFoNWEsofc6EA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=dPkl22TY; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=dPkl22TY; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 616428931 X-Spam-Score: -5.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: srvEe7dUjT/T --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, thanks for the bug report, and sorry for the breakage. Lars-Dominik Braun skriver: > Hi, > > after the update to libvirt 8.6.0 in > 3a76c2bfd94557c9776aa11240fec14580aec1b0 networks don=E2=80=99t start any= more: > > > LANG=3DC virsh net-start default > error: Failed to start network default > error: Unable to find 'dnsmasq' binary in $PATH: No such file or dire= ctory > > I tried to patch dnsmasq=E2=80=99s path like follows, but then the testca= se > networkxml2conftest fails and cannot find dnsmasq either. I don't understand why that test is failing with your patch. It has a hard coded "/usr/sbin/dnsmasq", but patching that does not make a difference. It seems the lookup via virFindFileInPath, which ultimately calls out to GLib's g_find_program_in_path, fails; but ostensibly using an absolute file name should not make a difference[0]. [0]: https://docs.gtk.org/glib/func.find_program_in_path.html Anyway, I was able to reproduce the failure in the system test: =2D-8<---------------cut here---------------start------------->8--- diff --git a/gnu/tests/virtualization.scm b/gnu/tests/virtualization.scm index 4bd56e5d9d..557f30db4f 100644 =2D-- a/gnu/tests/virtualization.scm +++ b/gnu/tests/virtualization.scm @@ -106,6 +106,26 @@ (define marionette "-c" "qemu:///system" "connect")) marionette)) =20 + (test-eq "create default network" + 0 + (marionette-eval + '(begin + (chdir "/tmp") + (system* #$(file-append libvirt "/bin/virsh") + "-c" "qemu:///system" "net-define" + #$(file-append libvirt + "/etc/libvirt/qemu/networks/defaul= t.xml"))) + marionette)) + + (test-eq "start default network" + 0 + (marionette-eval + '(begin + (chdir "/tmp") + (system* #$(file-append libvirt "/bin/virsh") + "-c" "qemu:///system" "net-start" "default")) + marionette)) + (test-end)))) =20 (gexp->derivation "libvirt-test" test)) =2D-8<---------------cut here---------------end--------------->8--- And can confirm your patch fixes that, which is arguably more important. So I went ahead and committed your patch (and disabled the failing test), and the system test to avoid future regressions in this area. Fixed in: acbf2f9def gnu: libvirt: Use absolute dnsmasq. 3e0abde17b tests: libvirt: Ensure the default network can be started. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYw0Qyw8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHeUKQD/f7qiFc0e4/Tearx6tjGwgDdIRNo7A/vTNq3o Klk5vssA/30BRf1DR736lepYN8DwO+9ow37L64GZ3JGwVhuC41UG =yT2G -----END PGP SIGNATURE----- --=-=-=--