From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ID5JF13ID2NHggAAbAwnHQ (envelope-from ) for ; Wed, 31 Aug 2022 22:45:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6Kw/F13ID2NqfwAA9RJhRA (envelope-from ) for ; Wed, 31 Aug 2022 22:45:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3809AC769 for ; Wed, 31 Aug 2022 22:45:17 +0200 (CEST) Received: from localhost ([::1]:59632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTUaK-0004yE-EY for larch@yhetil.org; Wed, 31 Aug 2022 16:45:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTUa7-0004xZ-RF for guix-patches@gnu.org; Wed, 31 Aug 2022 16:45:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTUa7-0008Js-IT for guix-patches@gnu.org; Wed, 31 Aug 2022 16:45:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oTUa6-0007yh-Cy for guix-patches@gnu.org; Wed, 31 Aug 2022 16:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56960] [PATCH] * gnu: Add siglo. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 31 Aug 2022 20:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56960 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Wamm K. D" Cc: Jean Pierre De Jesus DIAZ , "56960@debbugs.gnu.org" <56960@debbugs.gnu.org> Received: via spool by 56960-submit@debbugs.gnu.org id=B56960.166197869830636 (code B ref 56960); Wed, 31 Aug 2022 20:45:02 +0000 Received: (at 56960) by debbugs.gnu.org; 31 Aug 2022 20:44:58 +0000 Received: from localhost ([127.0.0.1]:40584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTUa2-0007y3-4g for submit@debbugs.gnu.org; Wed, 31 Aug 2022 16:44:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTUZx-0007xf-4C for 56960@debbugs.gnu.org; Wed, 31 Aug 2022 16:44:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTUZq-00087i-BF; Wed, 31 Aug 2022 16:44:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=sqNt4WZi0hAGQ1nkPIbMZQtpQ+bnjB9H/2jAWyCkyao=; b=JYvfmmcoNXPgXZphlEZi eCnkZi8NWcS7qNF/VgLlQ68PXk5cFTsbgDjJAQa9NSOtVM7bgneM2ye3siDs1zSZO3mTuLOniAwX+ 3UHLgUEHIh8iIU0SXAPMluMMSAE31XX01xzkkertMw+1UKSuGBpi5Nn+Gb7BHvq/PQOPioVim5ox9 Jg3b62LZ0Pl0nOt22zrhs1NDy5giAAX54eVDysNsLbk+uceeKokkmzbxHf1ckYyOooyPxjr/3QWW7 +6EugUm6PuPEHPb42IX+3sGFf8TtoGgH352XiDbdKqM2XuzSHDt4YC+s+M3Fh4Z7vGopsuMJ5lZYZ B5h/HnK1z6Cq+w==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60470 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTUZp-0005pY-Ox; Wed, 31 Aug 2022 16:44:45 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Wed, 31 Aug 2022 22:44:38 +0200 In-Reply-To: (Jean Pierre De Jesus DIAZ's message of "Thu, 11 Aug 2022 11:56:00 +0000") Message-ID: <87k06o9m89.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661978717; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sqNt4WZi0hAGQ1nkPIbMZQtpQ+bnjB9H/2jAWyCkyao=; b=VmHIITzwWlwOxsNiqaqGfd1nvj/p9xS/GYZzMRlyiTztscHx6/8JzyGlhO3GSH/xexsRB9 DF+Uhv+sUmQvSQB14AiO6E+FoXzxIhzPV1ZUb/08JGngo8LIypjnCzZL/MG5W9jPuVSJES sI2X/JAwWMKjVoeTTKF6SpKR0RfiT/vacWT34yIbzHn/qzi8yP25DC67YqlJmHS8mgZWUg eXRJoZEHoZgNqR22mRVUEEi858o6zv/CIOAXHjnVUtMOADR++Ja0uM2FNFGR9yhKeaY19v vA+8CpT+hLqPUCWOKSNgsQB50AhYOcF7Et0qeVT302qj6/2D5Y+RxXPIXmU5Wg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661978717; a=rsa-sha256; cv=none; b=gmzdZJOX8sFAID4p+Hn+gTGeJCBYphUEWnxZJcFXT1m2z1Al31brIG1yZlS/Y7qQhclWp0 zf30YzcFp8+5Mh+Xsez0WosJTBXoR7RFwByQca9ctSu8xezJyEgjjy/1UAA3hby8tAIwnW NNMIXyQp4MxR1nyknOY8tjOG6yn7csF3rCS8UPSQ8x9kdw9M10328Rwra2FZuOPxkZsXAA qL9RdWY4z8mVLvW1vpUg2lZOxPDIcwnGN4URlSviw9VmZnc+SHvmEozAmTaRb43RU0aLGt vh4WCcEr0dimxidmD9Jdr8aKoJjyT2MINbg5uyeA7YSofhg0ZkxCHaU+CNG9xg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=JYvfmmco; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=JYvfmmco; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3809AC769 X-Spam-Score: -2.18 X-Migadu-Scanner: scn1.migadu.com X-TUID: vTRYnvk9F2Ag Hi Wamm, Could you send an updated patch taking into accounts the comments made by Jean Pierre and Maxime? Thanks in advance! Ludo=E2=80=99. Jean Pierre De Jesus DIAZ skribis: > Hello, > > Just a quick review. > >>+ (url (string-append "https://github.com/alexr4535/" = name "/")) > > `name' is discouraged from being used on the source URL. > > If the package name changes, the URL does too. Can't recall where I saw i= t if > on the documentation or IRC. > >>+ (arguments >>+ `(#:glib-or-gtk? #t >>+ #:phases >>+ (modify-phases %standard-phases > > You'll probably want to use a list (argument (list ...)) instead of > quasi-quoting, and also, use G-Expressions, see (guix)G-Expressions: > > https://guix.gnu.org/manual/en/html_node/G_002dExpressions.html > > As the method used for the package is being phased out. > > For example: > > (arguments > (list #:glib-or-gtk? #t > #:phases > #~(modify-phases %standard-phases > ...))) > >>+ (wrap-program (string-append (assoc-ref outputs "out") >>+ "/bin/siglo") > > After using G-Expressions, this can be simplified to: > > (wrap-program (string-append #$output "/bin/siglo") > ...) > >>+ (synopsis "GTK app to sync InfiniTime watch with PinePhone") > > GTK is an implementation detail, no need to be specified, and if necessar= y, > better suited for the description. > > See (guix)Synopses and Descriptions: > > https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html > > For example, variations could include: > > * "Application to synchronize InfiniTime with PinePhone" > * "Synchronize InifniTime with PinePhone" > * "Smartwatch synchronization application" > * etc. > > Keep in mind that synopsis !=3D description. Probably someone with more e= xperience > than me could correct me on this topic. > >>+ (description "@code{siglo} is a graphical tool to flash InfiniTime fir= mware to >>+watches running the InfiniTime operating system, via bluetooth. > > flash -> update (non-technical term). > watches -> PineTime watches (or PineTime smartwatches). > bluetooth > Bluetooth. > >>+Users can also sync the time of their watch to the time of the device ru= nning >>+@code{siglo} as well as check the battery charge of their watch or what = version >>+of firmware their watch is running. > > sync -> synchronize. > > Maybe @itemize or @enumerate could be used to list the features provided,= like so: > > Siglo (or @code{siglo}) provides the following features: > > @itemize > @item Retrieve the version of the InfiniTime firmware running. > @item Check the battery charge. > @item Synchronize the time. > @end itemize > >>--- a/gnu/packages/flashing-tools.scm >>+++ b/gnu/packages/flashing-tools.scm > > Not entirely sure if this belongs in this category. Or if there's another= applicable. > > =E2=80=94 > Jean-Pierre De Jesus DIAZ