From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8NpjEhr4OWNvHwAAbAwnHQ (envelope-from ) for ; Sun, 02 Oct 2022 22:44:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ILc+Ehr4OWMFDQAAauVa8A (envelope-from ) for ; Sun, 02 Oct 2022 22:44:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 072DAF69E for ; Sun, 2 Oct 2022 22:44:10 +0200 (CEST) Received: from localhost ([::1]:38204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1of5on-0008Ff-5D for larch@yhetil.org; Sun, 02 Oct 2022 16:44:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1of5og-0008FP-Bs for guix-patches@gnu.org; Sun, 02 Oct 2022 16:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1of5og-00082j-4J for guix-patches@gnu.org; Sun, 02 Oct 2022 16:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1of5of-0005bb-Rb for guix-patches@gnu.org; Sun, 02 Oct 2022 16:44:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57960] [PATCH core-updates] gnu: libxkbcommon: Switch to gexp; adjust style. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Oct 2022 20:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57960 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Felix Lechner Cc: 57960@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 57960-submit@debbugs.gnu.org id=B57960.166474340521422 (code B ref 57960); Sun, 02 Oct 2022 20:44:01 +0000 Received: (at 57960) by debbugs.gnu.org; 2 Oct 2022 20:43:25 +0000 Received: from localhost ([127.0.0.1]:48172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of5o5-0005ZR-3S for submit@debbugs.gnu.org; Sun, 02 Oct 2022 16:43:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of5o2-0005ZE-JQ for 57960@debbugs.gnu.org; Sun, 02 Oct 2022 16:43:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52434) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1of5nu-00080c-Vi; Sun, 02 Oct 2022 16:43:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=3UtjWIOWdTqDZfWeyw8CwnY42EIXzBIpKX+Rd/9v7pk=; b=k8vqz6p9vBAa5IjujtUc cXfwFZqlq/iZCWRupgMlyM6C5Ag9QtFriVmGkoRY0zWuBqGCEqUgJl7MrLmYafXfDryumTDyD/zu8 6SLjAo9kKIqHGtWDpojxY/sfvR8zf5MpSk61xuQXxSNtWM4HuZVF/VPYX0qbghMmyeALe34hQWH+n oXKnH6fN3PxwrMyCcMayJPiwF+sN/aE2C+Jnjg8GStdwhoMJo+b/z+YyUWCc6qCEpTaF8toSH/JHr 1AI9aPnMolifFKRZCxAhCvOiBofYsbocDsH3w2ZNenpHlVAgLbiyf2JrtjlxWYv3zvkTt7Uj9eV95 LpUCkVWCiChclg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:50255 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1of5nu-0007z4-CR; Sun, 02 Oct 2022 16:43:14 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Sun, 02 Oct 2022 22:43:11 +0200 In-Reply-To: (Felix Lechner's message of "Wed, 21 Sep 2022 03:16:29 -0700") Message-ID: <87k05i9ctc.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664743450; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3UtjWIOWdTqDZfWeyw8CwnY42EIXzBIpKX+Rd/9v7pk=; b=Sh/Ts/s3v43QxkQZPPJ5YzKb/c16nBGpk8PESJtZaxYpYOkfyz/Mkxw73PoTG2mI3GYR8y trhBztl9XqoZtq/QLbZFj+jfWRrptJXBFHuN7arUdMll4lD87HY3HqnOoVcMe7XEeRTQbX wyC3QoT+qT1VDRyNTK4evOGtPJc198r8KOZgfJxlNLlAGacX9qZPhezJ/YEw5d3baMTLLI mXKs6rMNfonaQjAGkvHhEV9Sgcx4rfHR/reqScM7klrm0Ul12yJ3xGa4AyEnBewCI0F+bb PuJ2FE/Mz8CTCKvK0Ls00HCRSgS5w/EDrlITKtKYzgnK5Oaf36X/WOzzeMTYLw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664743450; a=rsa-sha256; cv=none; b=QBnzHDPZqReLBCi0IT7trvTDY2H6PZphLDy+NBJZPrq3UqFLmX1guxsJ10nxngQb0Q3SnN z5j/WczjczRLDmIXnB2fIHx552RqjmfInpTHf1zhqm0noydnjXVFqsqrvv+8mkXKesJfhh tE0Ly7tNl66t7VwXjXr1xTGXwV2CGNFAz8xE/YHTKmd/QOGvu3QcwHN2KsxH9EuvZR4J9B /e6EtMG21FG144kkrE6qhvIniduwDsGMu0cF7/LuuD1swqR09CwZPzEc/gvhFTa/oKxXUN WwLhk6CDp7GARc8TCQDoKiXgMZeu9ea/IgX8t9hmSAa9o8fOwnP3YTjNHE6RMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=k8vqz6p9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.24 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=k8vqz6p9; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 072DAF69E X-Spam-Score: -2.24 X-Migadu-Scanner: scn1.migadu.com X-TUID: ouJhnq7J3FDQ Hi Felix, Felix Lechner skribis: > From f07e9206be342f3e9769fe3dc14124b14444f139 Mon Sep 17 00:00:00 2001 > From: Felix Lechner > Date: Tue, 20 Sep 2022 09:47:35 -0700 > Subject: [PATCH] gnu: libxkbcommon: Switch to gexp; avoid hardcoding inpu= ts. > > * gnu/packages/xdisorg.scm (libxkbcommon): Switch to gexp. > [arguments]: Avoid hardcoding inputs and locate them via relative > paths instead. Applied, thanks! As a rule of thumb I agree that formatting changes should not be lumped together with other changes as that can hinder review. Regardless, I think a patch like this one should not be blocked for weeks for such tiny issues. Insisting on a rigorous process and conventions is important when it helps us all work together, but it=E2=80= =99s a problem when it hinders cooperation. As reviewers, we must strike for a balance that=E2=80=99s reasonable for everyone involved. Ludo=E2=80=99.