From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IJWQKG28eGOJ2QAAbAwnHQ (envelope-from ) for ; Sat, 19 Nov 2022 12:22:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WEBsKG28eGNOLAAAauVa8A (envelope-from ) for ; Sat, 19 Nov 2022 12:22:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A5A73FA0A for ; Sat, 19 Nov 2022 12:22:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owLvA-0007BT-U0; Sat, 19 Nov 2022 06:22:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owLv8-0007BB-Ou for guix-patches@gnu.org; Sat, 19 Nov 2022 06:22:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owLv8-0005YN-Fl for guix-patches@gnu.org; Sat, 19 Nov 2022 06:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owLv8-0008Qw-8s for guix-patches@gnu.org; Sat, 19 Nov 2022 06:22:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide. Resent-From: Sergiu Ivanov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Nov 2022 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 59352-done@debbugs.gnu.org Received: via spool by 59352-done@debbugs.gnu.org id=D59352.166885691832407 (code D ref 59352); Sat, 19 Nov 2022 11:22:02 +0000 Received: (at 59352-done) by debbugs.gnu.org; 19 Nov 2022 11:21:58 +0000 Received: from localhost ([127.0.0.1]:39114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owLv4-0008Qd-1e for submit@debbugs.gnu.org; Sat, 19 Nov 2022 06:21:58 -0500 Received: from marvid.fr ([163.172.81.107]:38850 helo=courriel.marvid.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owLuz-0008QL-VE for 59352-done@debbugs.gnu.org; Sat, 19 Nov 2022 06:21:56 -0500 Received: from localhost (schwifty.marvid.fr [51.159.4.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by sahkopoika (Postfix) with ESMTPSA id 80B7579C4D7A; Sat, 19 Nov 2022 12:21:47 +0100 (CET) References: <87v8ncbp09.fsf@colimite.fr> <87mt8oot15.fsf@nicolasgoaziou.fr> <874juvg6mc.fsf@colimite.fr> <87a64np9mv.fsf@nicolasgoaziou.fr> User-agent: mu4e 1.8.11; emacs 28.2 From: Sergiu Ivanov Date: Sat, 19 Nov 2022 12:18:07 +0100 In-reply-to: <87a64np9mv.fsf@nicolasgoaziou.fr> Message-ID: <87k03rdwac.fsf@colimite.fr> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668856941; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=k+56YxQ78Y7yEirLtkIL9JmN1+liO1R9wZGd3wl/NbM=; b=G7NafnURakAZLoXs+s5vEEijZboRrn5FbJxZmwD7zRqzqfwwq1ZFezEkmFv9GxUBAOy3L0 RXKggqiA5WTwdzuStAtV6sJxqr21+ppOepCmt2jtfZFR7hcMh6OkbaQjjLZ6WEOF/gArMe nzhGj9zPUspciJKzOaHIgUyntrNiYbIm1LF6SYBaJfg+Z/lDgBFtVStqHKgHiKLsOdSwxA x2hOQUdnjL43O8S4I3L3Dr0vrE7wSs178wytazhua7HWAuzymwNOzOAuF1TLTBwUBXHv90 VJHpCweWNSPXmqlV80YLZRr0OvXB4+z2cWRUZV8lT0hheFshaPTr+6z7J5+6Sw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668856941; a=rsa-sha256; cv=none; b=oHYzWpZMIlbrniUorlxhR+PxIj+JmGE4YVb2M6UIMB4P5wTRXqzOfAlG3O4InWWSkzLL1a YzYToH1xMTR/aMhV6Oay1rx2iZDDrJ0USJA+YFHnmVyam3wpnktb835JONKfBzZESywh3x 7eT2GcqrZsDJyna/fcu7w3Uj7OvDNeE80UujPKkJzoDNBwsPGK8VZ0NcBDxaSPsHwjFL5r YPykGVImnFnSHrJOEAtjwXzwjbrsnDCeltbFCSsjJKWglkHbh6ijXX2lqNoqHCfr59Ec2L lTSFnQyvOHjtbPonwjWicFeUGR2HHScLg++whJPpeNpUPyrnNYvTF7JOiVvFng== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.51 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3A5A73FA0A X-Spam-Score: -1.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: buUbarBGfe4g Hello, Nicolas Goaziou [2022-11-19T10:38:00+0100]: > Hello, > > Sergiu Ivanov writes: > >> So, I decided to update the existing definition and improve it according >> to your suggestions. I attach the new patch. > > Great! I applied it with a minor twist explained below. Great, thank you! >> Subject: [PATCH] gnu: emacs-org-tree-slide: Update to 2.8.18. >> >> * gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): Update to 2.8.18. > > You're updating to the latest commit, which is not exactly "2.8.18", to > "2.8.18-0.d6529bc". Oh, OK, thank you for the explanation! I am consistently bad at getting versioning right. > Also, the commit message must include changes you made to synopsis and > description, which could arguably have been done in a subsequent commit, > but that's fine. I hesitated about that. I'll split the changes over two patches the next time. >> --- >> gnu/packages/emacs-xyz.scm | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm >> index fe0d9f1dc9..f827107b29 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -18644,11 +18644,11 @@ (define-public emacs-kotlin-mode >> (license license:gpl3+)))) >> >> (define-public emacs-org-tree-slide >> - (let ((commit "036a36eec1cf712d3db155572aed325daa372eb5") >> - (revision "2")) >> + (let ((commit "d6529bc2df727d09014e0e56abf4f15a8e8fc20f") >> + (revision "3")) > > The revision is reset to "0" since you bumped the base version. Revision > is here to ensure monotonic growth between version bumps because commit > hashes cannot ensure this. Therefore, it is only useful to increase the > revision number within the same base version. Oh, I see! I read the docs of git-version to see what "revision" meant, but I didn't get that revision should be reset to 0 when the base version is changed. Thank you for taking the time to review my patch and explain the details! - Sergiu