From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oC+BNomQl2PoQAEAbAwnHQ (envelope-from ) for ; Mon, 12 Dec 2022 21:35:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UMqaNomQl2MENgEA9RJhRA (envelope-from ) for ; Mon, 12 Dec 2022 21:35:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A35743F5BD for ; Mon, 12 Dec 2022 21:35:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4pW2-000596-IF; Mon, 12 Dec 2022 15:35:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4pVw-00055N-IV for guix-patches@gnu.org; Mon, 12 Dec 2022 15:35:08 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4pVu-0003t6-Hu for guix-patches@gnu.org; Mon, 12 Dec 2022 15:35:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4pVu-0003eL-2X for guix-patches@gnu.org; Mon, 12 Dec 2022 15:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60014] [PATCH] activation: make install-special-file match against pairs as well. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 12 Dec 2022 20:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60014 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: mirai@makinata.eu, 60014@debbugs.gnu.org Cc: Bruno Victal Received: via spool by 60014-submit@debbugs.gnu.org id=B60014.167087725014012 (code B ref 60014); Mon, 12 Dec 2022 20:35:02 +0000 Received: (at 60014) by debbugs.gnu.org; 12 Dec 2022 20:34:10 +0000 Received: from localhost ([127.0.0.1]:55214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4pV3-0003dw-Kp for submit@debbugs.gnu.org; Mon, 12 Dec 2022 15:34:09 -0500 Received: from jpoiret.xyz ([206.189.101.64]:58714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4pV1-0003dq-U4 for 60014@debbugs.gnu.org; Mon, 12 Dec 2022 15:34:08 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id B8C9B1851DF; Mon, 12 Dec 2022 20:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1670877243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AUZX8qb1UKu2V1qyU9Sl4ZztHdwPVhB6v5PpZ1dkXkU=; b=Pyysp+NfHpstkVODU7QR/8tuHKEdmw3apg1pfUn4K3ER+G1ddmiu3nAFj2mDCj+MMFS9Vz dCKddLxMf6BF5Qc5yyI1PrkrgOKe0UMY1R2lXoB+drRF1IMHWiWERUC1NOCZavfMe87Fjb ePKh/3Sf/TzIHENmg8GZq89n5lwhkraaHUrvHq1jaX/jNjJIv4tBjRjoqwqv/f1eXp9xr1 +mxypkbVAPoZCQRUIjO2/c1OC3L2jhXXSdFdXUrLNGQdG5vSCCFdg+0dTqnv4RcUALdj88 ovLGD3iYqYKj+zUfoQuQGdL9dY8xzsP2YN9oY+lRmDliYVPWzvkvX18QPHkD5g== In-Reply-To: <43e937e1625b47a80887e68847fb8a8811d3f39f.1670867103.git.mirai@makinata.eu> References: <43e937e1625b47a80887e68847fb8a8811d3f39f.1670867103.git.mirai@makinata.eu> Date: Mon, 12 Dec 2022 21:34:02 +0100 Message-ID: <87k02wfjk5.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670877321; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=AUZX8qb1UKu2V1qyU9Sl4ZztHdwPVhB6v5PpZ1dkXkU=; b=hDI+I/kPGNgs5Istj4AkDbne2zHgRs2wkRzAyLZ18h0mPaimtDgE9TDzjxrAJeAoR6QUP8 SPS6sFSHxk4qvdIJuhz4xJoW5pwMuaq+cdrrjX0E/9DSUzwPiCfg5hZeQw+Byk5Yz1kSX/ z5FP58phGFVBBcjzYqZUjwEbOo74l2xTjliKq4wN2gyml01PsVPzvL4+oSFIcWH7kDYPtP n2rlCP/imNZk2xYyJG6InxsnKBfXqfdYkk1XuNA98rdVtf8+/WaH9zS44+32+/Gfgpmfco YFUuRINy+krrb4XElbQ7JdHOmd3NonDN3D0YdQkaaRXDhcKov3odE3AWpAOgQA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=Pyysp+Nf; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670877321; a=rsa-sha256; cv=none; b=OdKOJlZzI0ZoerCfJnRjpEqofANbwjLqgo03Llt0wtekqC1zc9sYoai7n2wf3mtYa0YT/l Yo6X1nVE3hKE8pS5YO3yFzs1EPZPBGWy4ElYGmFxeFtYNZBsQZ0zjUd0ykG3v8Yiv/WWEl wUEc7BXbnH+qPOoE5y0LQYtGk9BQt+GdJ+7M+cjan7QjvesBr+GczBntyOc/Xj4aTA7udQ IbUIMDpNacNalUrLBYRZaZt5byR8BGWuTD7FfHqzRIloXoNRA4KhfjIZ0ZkhtpETQ0nAsb dA57t92fZ2DH5Z1RT0h8h6edR9j8jKvaAxhfNeImBCB743+HYDvYymTbUgGqcA== X-Migadu-Spam-Score: -3.96 X-Spam-Score: -3.96 X-Migadu-Queue-Id: A35743F5BD X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=Pyysp+Nf; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: DNgpqsfE6321 Hi Bruno, Is this patch related to some specific problem you're running into? I personally would prefer keeping the special file interface as-is, and not mix two different kinds of entries: lists with 2 elements, and pairs. That would avoid having to manage even more edge-cases down the line if some more processing is needed. Otherwise, you're missing the ChangeLog entry format for the commit message, which you can find described at [1]. You can take some inspiration from other commits in the repository. Best, -- Josselin Poiret