From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id xlnvH8lKAmSfawEAbAwnHQ (envelope-from ) for ; Fri, 03 Mar 2023 20:30:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AO+qH8lKAmR7IwEAauVa8A (envelope-from ) for ; Fri, 03 Mar 2023 20:30:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0BDCE1C18C for ; Fri, 3 Mar 2023 20:30:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYB60-0006Oo-DK; Fri, 03 Mar 2023 14:29:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYB5t-0006JT-Co for guix-devel@gnu.org; Fri, 03 Mar 2023 14:29:30 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYB5r-0006yU-F5 for guix-devel@gnu.org; Fri, 03 Mar 2023 14:29:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=AiSkno1VQb+MN zHZsj90iwsWZ3ikr61SRzR7/82Bmfo=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=RLbaZ4LzuNQzfhJZiauFHLFd/PVgZ6PsXIzwiz qTihyt6/hh/UFI2ALBjFdstG2lMc9Pu0+bf+IdidNZ51cDPEvFi4eii0qx8rOJLRfp4oIH tGUD8fO/CIAQZDaVgXnLOLaCYwqz12FNGtk0wSYtgJSGS7HQbl9msKs7e++CEHofp0ifIl l+kmysUbXve9x+nzP7rSZJkAkrhpdQMhACm+QOFJjNiC7seGTmRNSwzwO4IUGPT4wQpr58 koFJP7yrfK4oCAAA6AghV7ApUPk72Hwclf3uEFeCGRJfMNU1MMgGqXnwl4UEWA6JFdQbyV j10DRefTYNzpmR9/KJHYJZFg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id b47f0853 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 3 Mar 2023 19:29:19 +0000 (UTC) References: <20230221130600.18932-1-sharlatanus@gmail.com> <20230226004406.6215-1-sharlatanus@gmail.com> <87ilfmhkuh.fsf_-_@gnu.org> <87lekijcwi.fsf@gmail.com> <87v8jixg6u.fsf@gnu.org> <87o7p94yqk.fsf@gmail.com> From: Tobias Geerinckx-Rice To: Maxim Cournoyer Cc: Simon Tournier , Guix Devel Subject: The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) Date: Fri, 03 Mar 2023 20:21:02 +0100 In-reply-to: <87o7p94yqk.fsf@gmail.com> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87jzzxy6l0.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677871817; a=rsa-sha256; cv=none; b=tDkLuizZmZ3LE8ucZjSUT/hg6X+e72BjmFbGT6Pjh6k9HU1dmpSy8AKU+b4M7Wn8P/a8NI WB+qJH/YVLh2nel3Sca+la9nD0I8a0qRYXlJXXat0wOLreBS34osPaaeebB9Jestm+Y5sp i6s5TOXzc+bSxymqyec44jHEXTU72je4U1o2ZacXnx8Le9K86n3TcshpHiBiTr+V0p4T7N M3C16CRtOEVye3jPXWg/3JFvMbYpf7EWxRMy0cN9rKjl0i3mrOtSubid9iNFuqBG4KUVED gaHZxac85ybkP5HdASxRhqrdweqon+5Sol0wBfKbsk08Kp6la0/Jw6Noz5GtcA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=tobias.gr header.s=2018 header.b=RLbaZ4Lz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=reject) header.from=tobias.gr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677871817; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AiSkno1VQb+MNzHZsj90iwsWZ3ikr61SRzR7/82Bmfo=; b=suMUMpAAS3oEjfSlbvz2culF3GoPE1Ohpw/QjuG4YH9nalcrYMKSx9k3MF+Al7Xex7DyRa sVb2HVEVbOhmVFiPVuxHKtr3szICM5ivJoHQl/KuKOiGoe8CS6jX/aPwI4aFOKxGrAsm5J ERX+jSRWwfTb2kKEO+mZ0k8lV8ejlSUt8h0zy0Yvcr6VswTZXNA2xfqPFlhuiokXU7El/2 YOjUAo7XqBNiAc8VuJtQ+hbk9AyP1YEdDNq+FmevwAF29KxO0feuj5NaCwmRqJ49LaTrQ1 FkEOagvX1qDz0QTAa667EpfrqfvLOMo8I56zERmm6ZNxpkZ5ZxG+IiHUHsV2QQ== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -6.44 X-Spam-Score: -6.44 X-Migadu-Queue-Id: 0BDCE1C18C Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=tobias.gr header.s=2018 header.b=RLbaZ4Lz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=reject) header.from=tobias.gr X-TUID: 5EBUd0DXCZ6S --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi! Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A > Simon Tournier writes: >> It is not clear for me why you choose one over the other. From=20 >> my >> current understanding, I would be tempted to always use >> 'package/inherit' and never plain 'inherit'. > > I also got confused by that in the past; Same. I think it's a rite of passage. A questionable one. > The way I process it internally now is this: > > If the inheritance is for *same-source/same-version* variants of=20 > a > package, they should use package/inherit, as any security issues=20 > found > in the parent package should also be applied to that package=20 > (since they > use the same source). Otherwise, plain 'inherit' should be used > (e.g. for newer version variants). That about jives with my intuition. Judging by the (IMO) universal confusion this causes, it is (IMO)=20 spectacularly poorly-named. A docstring doesn't fix that. Could we rename it to something like=20 =E2=80=98package+replacements/inherit=E2=80=99? To me, that captures the s= pirit,=20 without being overly longer. But I'll gladly judge other bikesheds if they lead to a less=20 misleading name. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCZAJLKw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15RkwBANOuLgPShDF8XxV6vVeJYZ75OWnkBQgztYl/An3m 57ERAP97tYG+lKsnm0Ueroza2AM/B+4qJ1KM0KXUFbxOlIstDg== =GvAB -----END PGP SIGNATURE----- --=-=-=--